Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(192)

Unified Diff: chrome/browser/ui/browser_commands.cc

Issue 25373009: Translate: New Bubble UX (for the view toolkit) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Add 'Try again' button; rename enum names Created 7 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/browser_commands.cc
diff --git a/chrome/browser/ui/browser_commands.cc b/chrome/browser/ui/browser_commands.cc
index a2660ef62dfff5770dfa10f347495dec53c52a55..fcc6fbf01740aef71ee14b95b9eadb021af24338 100644
--- a/chrome/browser/ui/browser_commands.cc
+++ b/chrome/browser/ui/browser_commands.cc
@@ -30,6 +30,7 @@
#include "chrome/browser/sessions/tab_restore_service.h"
#include "chrome/browser/sessions/tab_restore_service_delegate.h"
#include "chrome/browser/sessions/tab_restore_service_factory.h"
+#include "chrome/browser/translate/translate_tab_helper.h"
#include "chrome/browser/ui/bookmarks/bookmark_prompt_controller.h"
#include "chrome/browser/ui/bookmarks/bookmark_utils.h"
#include "chrome/browser/ui/browser.h"
@@ -49,6 +50,7 @@
#include "chrome/browser/ui/status_bubble.h"
#include "chrome/browser/ui/tab_contents/core_tab_helper.h"
#include "chrome/browser/ui/tabs/tab_strip_model.h"
+#include "chrome/browser/ui/translate/translate_bubble.h"
#include "chrome/browser/ui/webui/ntp/core_app_launcher_handler.h"
#include "chrome/browser/upgrade_detector.h"
#include "chrome/browser/web_applications/web_app.h"
@@ -679,6 +681,24 @@ bool CanBookmarkAllTabs(const Browser* browser) {
CanBookmarkCurrentPage(browser);
}
+void Translate(Browser* browser) {
Takashi Toyoshima 2013/10/08 14:54:09 We have similar implementation in render_view_cont
hajimehoshi 2013/10/10 11:07:10 This is slightly different from render_view_contex
+ if (browser->window()->IsActive()) {
+ WebContents* web_contents =
+ browser->tab_strip_model()->GetActiveWebContents();
+ TranslateTabHelper* translate_tab_helper =
+ TranslateTabHelper::FromWebContents(web_contents);
+
+ TranslateBubble::Type type = TranslateBubble::BEFORE_TRANSLATE;
+ if (translate_tab_helper) {
+ if (translate_tab_helper->language_state().translation_pending())
+ type = TranslateBubble::TRANSLATING;
+ else if (translate_tab_helper->language_state().IsPageTranslated())
+ type = TranslateBubble::AFTER_TRANSLATE;
+ }
+ browser->window()->ShowTranslateBubble(web_contents, type);
+ }
+}
+
void TogglePagePinnedToStartScreen(Browser* browser) {
#if defined(OS_WIN)
MetroPinTabHelper::FromWebContents(

Powered by Google App Engine
This is Rietveld 408576698