Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6242)

Unified Diff: chrome/browser/ui/views/location_bar/location_bar_view.h

Issue 25373009: Translate: New Bubble UX (for the view toolkit) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Bug fix: view id on tests Created 7 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/views/location_bar/location_bar_view.h
diff --git a/chrome/browser/ui/views/location_bar/location_bar_view.h b/chrome/browser/ui/views/location_bar/location_bar_view.h
index 6528681b998aeed87cc4610a5725ac19918168eb..49874d8b403b47bbefaa29e34f5fd6a3831a8e76 100644
--- a/chrome/browser/ui/views/location_bar/location_bar_view.h
+++ b/chrome/browser/ui/views/location_bar/location_bar_view.h
@@ -51,6 +51,7 @@ class ScriptBubbleIconView;
class SelectedKeywordView;
class StarView;
class TemplateURLService;
+class TranslateIconView;
class ZoomView;
namespace views {
@@ -185,6 +186,10 @@ class LocationBarView : public LocationBar,
// Returns the star view. It may not be visible.
StarView* star_view() { return star_view_; }
+ TranslateIconView* translate_icon_view() {
+ return translate_icon_view_;
+ }
+
// Shows the bookmark prompt.
void ShowBookmarkPrompt();
@@ -379,23 +384,29 @@ class LocationBarView : public LocationBar,
// after UpdateContentSettingViewsPreLayout() and a subsequent Layout().
void UpdateContentSettingViewsPostLayout();
- // Delete all page action views that we have created.
+ // Deletes all page action views that we have created.
void DeletePageActionViews();
- // Update the views for the Page Actions, to reflect state changes for
+ // Updates the views for the Page Actions, to reflect state changes for
// PageActions.
void RefreshPageActionViews();
// Returns the number of scripts currently running on the page.
size_t ScriptBubbleScriptsRunning();
- // Update the Script Bubble Icon, to reflect the number of content scripts
+ // Updates the Script Bubble Icon, to reflect the number of content scripts
// running on the page.
void RefreshScriptBubble();
- // Update the view for the zoom icon based on the current tab's zoom.
+ // Updates the view for the zoom icon based on the current tab's zoom.
void RefreshZoomView();
+ // Updates the Translate icon based on the current tab's Translate status.
+ void RefreshTranslateIcon();
+
+ // Sets the visibility of view to new_vis.
+ void ToggleVisibility(bool new_vis, views::View* view);
+
#if !defined(USE_AURA)
// Helper for the Mouse event handlers that does all the real work.
void OnMouseEvent(const ui::MouseEvent& event, UINT msg);
@@ -407,7 +418,7 @@ class LocationBarView : public LocationBar,
// Helper to show the first run info bubble.
void ShowFirstRunBubbleInternal();
- // Draw backgrounds and borders for page actions. Must be called
+ // Draws backgrounds and borders for page actions. Must be called
// after layout, so the |page_action_views_| have their bounds.
void PaintPageActionBackgrounds(gfx::Canvas* canvas);
@@ -492,6 +503,9 @@ class LocationBarView : public LocationBar,
// The star.
StarView* star_view_;
+ // The icon for Translate.
+ TranslateIconView* translate_icon_view_;
+
// Whether we're in popup mode. This value also controls whether the location
// bar is read-only.
const bool is_popup_mode_;
« no previous file with comments | « chrome/browser/ui/views/location_bar/bubble_icon_view.cc ('k') | chrome/browser/ui/views/location_bar/location_bar_view.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698