chrome/browser/translate/translate_tab_helper.cc - Issue 25373009: Translate: New Bubble UX (for the view toolkit)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/translate/translate_tab_helper.cc

Issue 25373009: Translate: New Bubble UX (for the view toolkit) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Bug fix: view id on tests Created 7 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/translate/translate_tab_helper.cc

diff --git a/chrome/browser/translate/translate_tab_helper.cc b/chrome/browser/translate/translate_tab_helper.cc

index 4cf6ddad938bd410b397fc5cc8d5f8e43cd660b4..c2dd240973075b055d3869086663fbe3d2186e97 100644

--- a/chrome/browser/translate/translate_tab_helper.cc

+++ b/chrome/browser/translate/translate_tab_helper.cc

@@ -60,7 +60,10 @@ void TranslateTabHelper::OnPageTranslated(int32 page_id,

TranslateErrors::Type error_type) {

language_state_.set_current_language(translated_lang);

language_state_.set_translation_pending(false);

- PageTranslatedDetails details(original_lang, translated_lang, error_type);

+ PageTranslatedDetails details;

+ details.source_language = original_lang;

+ details.target_language = translated_lang;

+ details.error_type = error_type;

content::NotificationService::current()->Notify(

chrome::NOTIFICATION_PAGE_TRANSLATED,

content::Source<WebContents>(web_contents()),