chrome/browser/ui/cocoa/browser_window_cocoa.mm - Issue 25373009: Translate: New Bubble UX (for the view toolkit)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/browser_window_cocoa.mm

Issue 25373009: Translate: New Bubble UX (for the view toolkit) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Add the browser test Created 7 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/cocoa/browser_window_cocoa.mm

diff --git a/chrome/browser/ui/cocoa/browser_window_cocoa.mm b/chrome/browser/ui/cocoa/browser_window_cocoa.mm

index 230ba44f46ce8c808a36d39322bc0dfdc1dfe6dc..1d2ef5d65195c1ee0585bcb70f3d36c8ade8c794 100644

--- a/chrome/browser/ui/cocoa/browser_window_cocoa.mm

+++ b/chrome/browser/ui/cocoa/browser_window_cocoa.mm

@@ -493,6 +493,11 @@ void BrowserWindowCocoa::ShowBookmarkBubble(const GURL& url,

alreadyBookmarked:(already_bookmarked ? YES : NO)];

}

+void BrowserWindowCocoa::ShowTranslateBubble(

+ content::WebContents* contents,

+ TranslateBubbleModel::ViewState view_state) {

#if defined(ENABLE_ONE_CLICK_SIGNIN)

void BrowserWindowCocoa::ShowOneClickSigninBubble(

OneClickSigninBubbleType type,