Translate: New Bubble UX (for the view toolkit)

chrome/browser/tab_contents/language_state.cc

Index: chrome/browser/tab_contents/language_state.cc
diff --git a/chrome/browser/tab_contents/language_state.cc b/chrome/browser/tab_contents/language_state.cc
index eb298954ec86feeba2233d525eea723d77f2f644..b729d923ad1fefffc767a4f761344e6f7b9d2d1c 100644
--- a/chrome/browser/tab_contents/language_state.cc
+++ b/chrome/browser/tab_contents/language_state.cc
@@ -7,6 +7,7 @@
 #include "content/public/browser/navigation_controller.h"
 #include "content/public/browser/navigation_details.h"
 #include "content/public/browser/navigation_entry.h"
+#include "content/public/browser/web_contents.h"
 
 using content::NavigationController;
 
@@ -15,7 +16,9 @@ LanguageState::LanguageState(NavigationController* nav_controller)
       page_needs_translation_(false),
       translation_pending_(false),
       translation_declined_(false),
-      in_page_navigation_(false) {
+      in_page_navigation_(false),
+      translate_enabled_(false),
+      observer_(NULL) {
 }
 
 LanguageState::~LanguageState() {
@@ -44,6 +47,8 @@ void LanguageState::DidNavigate(
 
   translation_pending_ = false;
   translation_declined_ = false;
+
+  SetTranslateEnabled(false);

[sky, 2013/10/18 14:31:10]

It's unusual that this property implicitly changes on navigation.

[hajimehoshi, 2013/10/22 10:30:25]

This is necessary to hide the translate icon on the Omnibox when the page is
navigated. I don't think it is better to move calling SetTranslateEnabled to the
caller of DidNavigate.

 }
 
 void LanguageState::LanguageDetermined(const std::string& page_language,
@@ -84,3 +89,19 @@ std::string LanguageState::AutoTranslateTo() const {
 
   return std::string();
 }
+
+void LanguageState::SetTranslateEnabled(bool value) {
+  if (translate_enabled_ == value)
+    return;
+
+  translate_enabled_ = value;
+  if (observer_) {
+    content::WebContents* web_contents =
+        navigation_controller_->GetWebContents();
+    observer_->OnTranslateEnabledChanged(web_contents);
+  }
+}
+
+bool LanguageState::IsLanguageChanged() const {
+  return original_lang_ != prev_original_lang_;
+}