Translate: New Bubble UX (for the view toolkit)

chrome/browser/ui/views/location_bar/bubble_icon_view_delegate.h

+// Copyright 2013 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef CHROME_BROWSER_UI_VIEWS_LOCATION_BAR_BUBBLE_ICON_VIEW_DELEGATE_H_
+#define CHROME_BROWSER_UI_VIEWS_LOCATION_BAR_BUBBLE_ICON_VIEW_DELEGATE_H_
+
+// The delegate for BubbleIconView.
+class BubbleIconViewDelegate {

[sky, 2013/10/23 14:43:29]

There is no point in both subclassing *and* having a delegate. If you can't get
the delegate to work, which it appears each needs to subclass for different
reasons, then nuke the delegate and have pure virtual methods.

[hajimehoshi, 2013/10/24 11:31:14]

Done.

+ public:
+  virtual ~BubbleIconViewDelegate() {}
+
+  // Returns true if a related bubble is already shown.
+  virtual bool IsBubbleShowing() const = 0;
+
+  // Handles when the command is executed by mouse event.
+  virtual void OnExecutingByMouse() = 0;

[sky, 2013/10/23 14:43:29]

Add an enum and a single OnExecute(EXECUTE_SOURCE) method.

[hajimehoshi, 2013/10/24 11:31:14]

Done.

+
+  // Handles when the command is executed by key event.
+  virtual void OnExecutingByKey() = 0;
+
+  // Handles when the command is executed by gesture event.
+  virtual void OnExecutingByGesture() = 0;
+};
+
+#endif  // CHROME_BROWSER_UI_VIEWS_LOCATION_BAR_BUBBLE_ICON_VIEW_DELEGATE_H_