Translate: New Bubble UX (for the view toolkit)

chrome/browser/translate/translate_manager_browsertest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <algorithm>
 #include <set>
 #include <vector>
 
+#include "base/command_line.h"
 #include "base/memory/scoped_ptr.h"
 #include "base/prefs/pref_change_registrar.h"
 #include "base/prefs/pref_service.h"
 #include "base/strings/stringprintf.h"
 #include "chrome/app/chrome_command_ids.h"
 #include "chrome/browser/chrome_notification_types.h"
 #include "chrome/browser/extensions/test_extension_system.h"
 #include "chrome/browser/infobars/infobar.h"
 #include "chrome/browser/infobars/infobar_service.h"
 #include "chrome/browser/prefs/session_startup_pref.h"
 #include "chrome/browser/tab_contents/render_view_context_menu.h"
+#include "chrome/browser/translate/translate_bubble_showable.h"
 #include "chrome/browser/translate/translate_infobar_delegate.h"
 #include "chrome/browser/translate/translate_language_list.h"
 #include "chrome/browser/translate/translate_manager.h"
 #include "chrome/browser/translate/translate_prefs.h"
 #include "chrome/browser/translate/translate_script.h"
 #include "chrome/browser/translate/translate_tab_helper.h"
 #include "chrome/browser/ui/browser.h"
 #include "chrome/browser/ui/tabs/tab_strip_model.h"
+#include "chrome/browser/ui/translate/translate_bubble_model.h"
+#include "chrome/browser/ui/translate/translate_bubble_model_impl.h"
+#include "chrome/common/chrome_switches.h"
 #include "chrome/common/pref_names.h"
 #include "chrome/common/render_messages.h"
 #include "chrome/common/translate/language_detection_details.h"
 #include "chrome/common/url_constants.h"
 #include "chrome/test/base/chrome_render_view_host_test_harness.h"
 #include "chrome/test/base/in_process_browser_test.h"
 #include "chrome/test/base/testing_browser_process.h"
 #include "chrome/test/base/testing_profile.h"
 #include "chrome/test/base/ui_test_utils.h"
 #include "content/public/browser/navigation_details.h"
@@ skipping 279 matching lines @@
   content::NotificationRegistrar notification_registrar_;
   net::TestURLFetcherFactory url_fetcher_factory_;
 
   // The infobars that have been removed.
   // WARNING: the pointers point to deleted objects, use only for comparison.
   std::set<InfoBarDelegate*> removed_infobars_;
 
   DISALLOW_COPY_AND_ASSIGN(TranslateManagerBrowserTest);
 };
 
+class MockTranslateBubbleShowable : public TranslateBubbleShowable {
+ public:
+  MockTranslateBubbleShowable() {
+  }
+
+  virtual void Show(content::WebContents* web_contents,
+                    TranslateBubbleModel::ViewState view_state) OVERRIDE {
+    if (model_) {
+      model_->SetViewState(view_state);
+      return;
+    }
+
+    TranslateTabHelper* translate_tab_helper =
+        TranslateTabHelper::FromWebContents(web_contents);
+    std::string source_language =
+        translate_tab_helper->language_state().original_language();
+    std::string target_language = TranslateManager::GetLanguageCode(
+        g_browser_process->GetApplicationLocale());
+    scoped_ptr<TranslateUIDelegate> ui_delegate(
+        new TranslateUIDelegate(web_contents,
+                                source_language,
+                                target_language));
+    model_.reset(
+        new TranslateBubbleModelImpl(view_state, ui_delegate.Pass()));
+  }
+
+  TranslateBubbleModel* model() { return model_.get(); }
+
+ private:
+  scoped_ptr<TranslateBubbleModel> model_;
+
+  DISALLOW_COPY_AND_ASSIGN(MockTranslateBubbleShowable);
+};
+
 namespace {
 
 class TestRenderViewContextMenu : public RenderViewContextMenu {
  public:
   static TestRenderViewContextMenu* CreateContextMenu(
       content::WebContents* web_contents) {
     content::ContextMenuParams params;
     params.media_type = WebKit::WebContextMenuData::MediaTypeNone;
     params.x = 0;
     params.y = 0;
@@ skipping 1066 matching lines @@
   EXPECT_EQ("en", target_lang);
 }
 
 TEST_F(TranslateManagerBrowserTest, DownloadsAndHistoryNotTranslated) {
   ASSERT_FALSE(TranslateManager::IsTranslatableURL(
       GURL(chrome::kChromeUIDownloadsURL)));
   ASSERT_FALSE(TranslateManager::IsTranslatableURL(
       GURL(chrome::kChromeUIHistoryURL)));
 }
 
+TEST_F(TranslateManagerBrowserTest, BubbleNormalTranslate) {
+  // Prepare for the bubble
+  CommandLine* command_line = CommandLine::ForCurrentProcess();
+  command_line->AppendSwitch(switches::kEnableTranslateNewUX);
+  MockTranslateBubbleShowable* showable = new MockTranslateBubbleShowable;
+  scoped_ptr<TranslateBubbleShowable> showable_ptr(showable);
+  TranslateManager::GetInstance()->SetTranslateBubbleShowable(
+      showable_ptr.Pass());
+
+  SimulateNavigation(GURL("http://www.google.fr"), "fr", true);
+
+  // Check the bubble exists instead of the infobar.
+  TranslateInfoBarDelegate* infobar = GetTranslateInfoBar();
+  ASSERT_TRUE(infobar == NULL);
+  TranslateBubbleModel* bubble = showable->model();
+  ASSERT_TRUE(bubble != NULL);
+  EXPECT_EQ(TranslateBubbleModel::VIEW_STATE_BEFORE_TRANSLATE,
+            bubble->GetViewState());
+
+  // Simulate clicking translate.
+  process()->sink().ClearMessages();
+  bubble->Translate();
+
+  // Check the bubble shows "Translating...".
+  bubble = showable->model();
+  ASSERT_TRUE(bubble != NULL);
+  EXPECT_EQ(TranslateBubbleModel::VIEW_STATE_TRANSLATING,
+            bubble->GetViewState());
+
+  // Simulate the translate script being retrieved (it only needs to be done
+  // once in the test as it is cached).
+  SimulateTranslateScriptURLFetch(true);
+
+  // Simulate the render notifying the translation has been done.
+  SimulateOnPageTranslated("fr", "en");
+
+  // Check the bubble shows "Translated."
+  bubble = showable->model();
+  ASSERT_TRUE(bubble != NULL);
+  EXPECT_EQ(TranslateBubbleModel::VIEW_STATE_AFTER_TRANSLATE,
+            bubble->GetViewState());
+}
+
+TEST_F(TranslateManagerBrowserTest, BubbleTranslateScriptNotAvailable) {
+  // Prepare for the bubble
+  CommandLine* command_line = CommandLine::ForCurrentProcess();
+  command_line->AppendSwitch(switches::kEnableTranslateNewUX);
+  MockTranslateBubbleShowable* showable = new MockTranslateBubbleShowable;
+  scoped_ptr<TranslateBubbleShowable> showable_ptr(showable);
+  TranslateManager::GetInstance()->SetTranslateBubbleShowable(
+      showable_ptr.Pass());
+
+  SimulateNavigation(GURL("http://www.google.fr"), "fr", true);
+
+  // Check the bubble exists instead of the infobar.
+  TranslateInfoBarDelegate* infobar = GetTranslateInfoBar();
+  ASSERT_TRUE(infobar == NULL);
+  TranslateBubbleModel* bubble = showable->model();
+  ASSERT_TRUE(bubble != NULL);
+  EXPECT_EQ(TranslateBubbleModel::VIEW_STATE_BEFORE_TRANSLATE,
+            bubble->GetViewState());
+
+  // Simulate clicking translate.
+  process()->sink().ClearMessages();
+  bubble->Translate();
+  SimulateTranslateScriptURLFetch(false);
+
+  // We should not have sent any message to translate to the renderer.
+  EXPECT_FALSE(GetTranslateMessage(NULL, NULL, NULL));
+
+  // And we should have an error infobar showing.
+  bubble = showable->model();
+  ASSERT_TRUE(bubble != NULL);
+  EXPECT_EQ(TranslateBubbleModel::VIEW_STATE_ERROR,
+            bubble->GetViewState());
+}
+
+TEST_F(TranslateManagerBrowserTest, BubbleUnknownLanguage) {
+  // Prepare for the bubble
+  CommandLine* command_line = CommandLine::ForCurrentProcess();
+  command_line->AppendSwitch(switches::kEnableTranslateNewUX);
+  MockTranslateBubbleShowable* showable = new MockTranslateBubbleShowable;
+  scoped_ptr<TranslateBubbleShowable> showable_ptr(showable);
+  TranslateManager::GetInstance()->SetTranslateBubbleShowable(
+      showable_ptr.Pass());
+
+  // Simulate navigating to a page ("und" is the string returned by the CLD for
+  // languages it does not recognize).
+  SimulateNavigation(GURL("http://www.google.mys"), "und", true);
+
+  // We should not have a bubble as we don't know the language.
+  ASSERT_TRUE(showable->model() == NULL);
+
+  // Translate the page anyway throught the context menu.
+  scoped_ptr<TestRenderViewContextMenu> menu(
+      TestRenderViewContextMenu::CreateContextMenu(web_contents()));
+  menu->Init();
+  menu->ExecuteCommand(IDC_CONTENT_CONTEXT_TRANSLATE, 0);
+
+  // Check the bubble exists instead of the infobar.
+  TranslateInfoBarDelegate* infobar = GetTranslateInfoBar();
+  ASSERT_TRUE(infobar == NULL);
+  TranslateBubbleModel* bubble = showable->model();
+  ASSERT_TRUE(bubble != NULL);
+  EXPECT_EQ(TranslateBubbleModel::VIEW_STATE_TRANSLATING,
+            bubble->GetViewState());
+}
+
 // Test is flaky on Win http://crbug.com/166334
 #if defined(OS_WIN)
 #define MAYBE_PRE_TranslateSessionRestore DISABLED_PRE_TranslateSessionRestore
 #else
 #define MAYBE_PRE_TranslateSessionRestore PRE_TranslateSessionRestore
 #endif
 // Test that session restore restores the translate infobar and other translate
 // settings.
 IN_PROC_BROWSER_TEST_F(InProcessBrowserTest,
                        MAYBE_PRE_TranslateSessionRestore) {
@@ skipping 31 matching lines @@
   content::WebContents* current_web_contents =
       browser()->tab_strip_model()->GetActiveWebContents();
   content::Source<content::WebContents> source(current_web_contents);
 
   ui_test_utils::WindowedNotificationObserverWithDetails<
     LanguageDetectionDetails>
       fr_language_detected_signal(chrome::NOTIFICATION_TAB_LANGUAGE_DETERMINED,
                                   source);
   fr_language_detected_signal.Wait();
 }