Translate: New Bubble UX (for the view toolkit)

chrome/browser/ui/browser_window.h

 // Copyright 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_UI_BROWSER_WINDOW_H_
 #define CHROME_BROWSER_UI_BROWSER_WINDOW_H_
 
 #include "base/callback_forward.h"
 #include "chrome/browser/lifetime/browser_close_manager.h"
 #include "chrome/browser/ui/bookmarks/bookmark_bar.h"
 #include "chrome/browser/ui/browser.h"
 #include "chrome/browser/ui/fullscreen/fullscreen_exit_bubble_type.h"
 #include "chrome/browser/ui/host_desktop.h"
 #include "chrome/browser/ui/sync/one_click_signin_sync_starter.h"
+#include "chrome/browser/ui/translate/translate_bubble.h"
 #include "chrome/common/content_settings_types.h"
 #include "ui/base/base_window.h"
 #include "ui/base/window_open_disposition.h"
 #include "ui/gfx/native_widget_types.h"
 
 class Browser;
 class BrowserWindowTesting;
 class DownloadShelf;
 class FindBar;
 class GURL;
@@ skipping 190 matching lines @@
   virtual void ShowUpdateChromeDialog() = 0;
 
   // Shows the Bookmark bubble. |url| is the URL being bookmarked,
   // |already_bookmarked| is true if the url is already bookmarked.
   virtual void ShowBookmarkBubble(const GURL& url, bool already_bookmarked) = 0;
 
   // Shows the bookmark prompt.
   // TODO(yosin): Make ShowBookmarkPrompt pure virtual.
   virtual void ShowBookmarkPrompt() {}
 
+  // Shows the translate bubble.
+  // TODO(hajimehoshi): Make this pure virtual.

[Takashi Toyoshima, 2013/10/08 14:54:09]

Yeah, this TODO means we don't implement this method in any child class for
testing. At least, file a bug for this, and add an URL link for that here. And
of course, writing a test is better than that.

[hajimehoshi, 2013/10/10 11:07:10]

OK, I'll write the test.

+  virtual void ShowTranslateBubble(content::WebContents* contents,
+                                   TranslateBubble::Type type) {}
+
 #if defined(ENABLE_ONE_CLICK_SIGNIN)
   enum OneClickSigninBubbleType {
     ONE_CLICK_SIGNIN_BUBBLE_TYPE_BUBBLE,
     ONE_CLICK_SIGNIN_BUBBLE_TYPE_MODAL_DIALOG,
     ONE_CLICK_SIGNIN_BUBBLE_TYPE_SAML_MODAL_DIALOG
   };
 
   // Callback type used with the ShowOneClickSigninBubble() method.  If the
   // user chooses to accept the sign in, the callback is called to start the
   // sync process.
@@ skipping 172 matching lines @@
 
   // Returns the ToolbarView.
   virtual ToolbarView* GetToolbarView() const = 0;
 #endif
 
  protected:
   virtual ~BrowserWindowTesting() {}
 };
 
 #endif  // CHROME_BROWSER_UI_BROWSER_WINDOW_H_