Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(692)

Side by Side Diff: chrome/browser/ui/views/location_bar/bubble_icon_view.cc

Issue 25373009: Translate: New Bubble UX (for the view toolkit) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Bug fix: view id on tests Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
(Empty)
1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file.
4
5 #include "chrome/browser/ui/views/location_bar/bubble_icon_view.h"
6
7 #include "chrome/browser/command_updater.h"
8 #include "chrome/browser/ui/views/location_bar/location_bar_view.h"
9 #include "ui/base/accessibility/accessible_view_state.h"
10 #include "ui/events/event.h"
11
12 BubbleIconView::BubbleIconView(CommandUpdater* command_updater, int command_id)
13 : command_updater_(command_updater),
14 command_id_(command_id),
15 suppress_mouse_released_action_(false) {
16 set_accessibility_focusable(true);
17 LocationBarView::InitTouchableLocationBarChildView(this);
18 }
19
20 BubbleIconView::~BubbleIconView() {
21 }
22
23 void BubbleIconView::GetAccessibleState(ui::AccessibleViewState* state) {
24 views::ImageView::GetAccessibleState(state);
25 state->role = ui::AccessibilityTypes::ROLE_PUSHBUTTON;
26 }
27
28 bool BubbleIconView::GetTooltipText(const gfx::Point& p,
29 string16* tooltip) const {
30 if (IsBubbleShowing())
31 return false;
32
33 return views::ImageView::GetTooltipText(p, tooltip);
34 }
35
36 bool BubbleIconView::OnMousePressed(const ui::MouseEvent& event) {
37 // If the bubble is showing then don't reshow it when the mouse is released.
38 suppress_mouse_released_action_ = IsBubbleShowing();
39
40 // We want to show the bubble on mouse release; that is the standard behavior
41 // for buttons.
42 return true;
43 }
44
45 void BubbleIconView::OnMouseReleased(const ui::MouseEvent& event) {
46 // If this is the second click on this view then the bubble was showing on the
47 // mouse pressed event and is hidden now. Prevent the bubble from reshowing by
48 // doing nothing here.
49 if (suppress_mouse_released_action_) {
50 suppress_mouse_released_action_ = false;
51 return;
52 }
53
54 if (event.IsOnlyLeftMouseButton() && HitTestPoint(event.location())) {
55 OnExecuting(EXECUTE_SOURCE_MOUSE);
56 command_updater_->ExecuteCommand(command_id_);
57 }
58 }
59
60 bool BubbleIconView::OnKeyPressed(const ui::KeyEvent& event) {
61 if (event.key_code() == ui::VKEY_SPACE ||
62 event.key_code() == ui::VKEY_RETURN) {
63 OnExecuting(EXECUTE_SOURCE_KEYBOARD);
64 command_updater_->ExecuteCommand(command_id_);
65 return true;
66 }
67 return false;
68 }
69
70 void BubbleIconView::OnGestureEvent(ui::GestureEvent* event) {
71 if (event->type() == ui::ET_GESTURE_TAP) {
72 OnExecuting(EXECUTE_SOURCE_GESTURE);
73 command_updater_->ExecuteCommand(command_id_);
74 event->SetHandled();
75 }
76 }
OLDNEW
« no previous file with comments | « chrome/browser/ui/views/location_bar/bubble_icon_view.h ('k') | chrome/browser/ui/views/location_bar/location_bar_view.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698