chrome/browser/translate/translate_tab_helper.cc - Issue 25373009: Translate: New Bubble UX (for the view toolkit)

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/browser/translate/translate_tab_helper.cc

Issue 25373009: Translate: New Bubble UX (for the view toolkit) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Add the browser test Created 7 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« chrome/browser/translate/translate_bubble_browsertest.cc ('K') | « chrome/browser/translate/translate_manager_browsertest.cc ('k') | chrome/browser/translate/translate_ui_delegate.cc » ('j') | chrome/browser/ui/browser.h » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.	1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #include "chrome/browser/translate/translate_tab_helper.h"	5 #include "chrome/browser/translate/translate_tab_helper.h"

6	6

7 #include "chrome/browser/chrome_notification_types.h"	7 #include "chrome/browser/chrome_notification_types.h"

8 #include "chrome/browser/translate/page_translated_details.h"	8 #include "chrome/browser/translate/page_translated_details.h"

9 #include "chrome/common/render_messages.h"	9 #include "chrome/common/render_messages.h"

10 #include "chrome/common/translate/language_detection_details.h"	10 #include "chrome/common/translate/language_detection_details.h"

(...skipping 42 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
53 content::Source<WebContents>(web_contents()),	53 content::Source<WebContents>(web_contents()),

54 content::Details<const LanguageDetectionDetails>(&details));	54 content::Details<const LanguageDetectionDetails>(&details));

55 }	55 }

56	56

57 void TranslateTabHelper::OnPageTranslated(int32 page_id,	57 void TranslateTabHelper::OnPageTranslated(int32 page_id,

58 const std::string& original_lang,	58 const std::string& original_lang,

59 const std::string& translated_lang,	59 const std::string& translated_lang,

60 TranslateErrors::Type error_type) {	60 TranslateErrors::Type error_type) {

61 language_state_.set_current_language(translated_lang);	61 language_state_.set_current_language(translated_lang);

62 language_state_.set_translation_pending(false);	62 language_state_.set_translation_pending(false);

63 PageTranslatedDetails details(original_lang, translated_lang, error_type);	63 PageTranslatedDetails details;

	64 details.source_language = original_lang;

	65 details.target_language = translated_lang;

	66 details.error_type = error_type;

64 content::NotificationService::current()->Notify(	67 content::NotificationService::current()->Notify(

65 chrome::NOTIFICATION_PAGE_TRANSLATED,	68 chrome::NOTIFICATION_PAGE_TRANSLATED,

66 content::Source<WebContents>(web_contents()),	69 content::Source<WebContents>(web_contents()),

67 content::Details<PageTranslatedDetails>(&details));	70 content::Details<PageTranslatedDetails>(&details));

68 }	71 }

OLD	NEW