Source/core/rendering/RenderBlock.cpp - Issue 25373006: Correction to layoutOverflowRect in case of direction:rtl

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/rendering/RenderBlock.cpp

Issue 25373006: Correction to layoutOverflowRect in case of direction:rtl (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 7 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « LayoutTests/scrollbars/rtl/div-horizontal-with-vertical-scrollbar-expected.txt ('k') | Source/core/rendering/RenderBox.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/core/rendering/RenderBlock.cpp

diff --git a/Source/core/rendering/RenderBlock.cpp b/Source/core/rendering/RenderBlock.cpp

index addd983b148134734424a7ec70f1afce908e1af5..fcd6a112c52f23a6c722f503ed0c2e68f89104ce 100644

--- a/Source/core/rendering/RenderBlock.cpp

+++ b/Source/core/rendering/RenderBlock.cpp

@@ -1546,12 +1546,8 @@ void RenderBlock::addOverflowFromPositionedObjects()

positionedObject = *it;

// Fixed positioned elements don't contribute to layout overflow, since they don't scroll with the content.

- if (positionedObject->style()->position() != FixedPosition) {

- LayoutUnit x = positionedObject->x();

- if (style()->shouldPlaceBlockDirectionScrollbarOnLogicalLeft())

- x -= verticalScrollbarWidth();

- addOverflowFromChild(positionedObject, LayoutSize(x, positionedObject->y()));

- }

+ if (positionedObject->style()->position() != FixedPosition)

+ addOverflowFromChild(positionedObject, LayoutSize(positionedObject->x(), positionedObject->y()));

}