Correction to layoutOverflowRect in case of direction:rtl

Source/core/rendering/RenderBlock.cpp

Index: Source/core/rendering/RenderBlock.cpp
diff --git a/Source/core/rendering/RenderBlock.cpp b/Source/core/rendering/RenderBlock.cpp
index 24f3f026f6c14b1e10536b4590f4c9f3dfa0b941..0bc32889344d1449f7385a5dbe360b095faa4399 100644
--- a/Source/core/rendering/RenderBlock.cpp
+++ b/Source/core/rendering/RenderBlock.cpp
@@ -1644,12 +1644,8 @@ void RenderBlock::addOverflowFromPositionedObjects()
         positionedObject = *it;
 
         // Fixed positioned elements don't contribute to layout overflow, since they don't scroll with the content.
-        if (positionedObject->style()->position() != FixedPosition) {
-            LayoutUnit x = positionedObject->x();
-            if (style()->shouldPlaceBlockDirectionScrollbarOnLogicalLeft())
-                x -= verticalScrollbarWidth();

[Julien - ping for review, 2013/10/30 02:03:41]

Is this code tested somewhere?

[pals, 2013/10/30 12:02:13]

Are you talking about LayoutTests? I have written a layout test which tests this
code and there are few existing tests need to be rebaselined.

[Julien - ping for review, 2013/11/01 00:29:13]

Yes, I was talking about LayoutTests. And no, your new test cannot cover this
code path: you don't have positioned elements. I don't think any of the
rebaselined test do cover this code path either.

However scrollbars/rtl/div-absolute.html clearly fails if you don't have this
change so yes we have some coverage.

-            addOverflowFromChild(positionedObject, LayoutSize(x, positionedObject->y()));
-        }
+        if (positionedObject->style()->position() != FixedPosition)
+            addOverflowFromChild(positionedObject, LayoutSize(positionedObject->x(), positionedObject->y()));
     }
 }