Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(498)

Side by Side Diff: src/x64/lithium-x64.cc

Issue 25373003: Remove unnecessary MarkAsDeferredCalling when changing a tagged value to double (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 7 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/mips/lithium-mips.cc ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 1804 matching lines...) Expand 10 before | Expand all | Expand 10 after
1815 LOperand* value = UseRegister(instr->value()); 1815 LOperand* value = UseRegister(instr->value());
1816 return DefineSameAsFirst(new(zone()) LDummyUse(value)); 1816 return DefineSameAsFirst(new(zone()) LDummyUse(value));
1817 } 1817 }
1818 from = Representation::Tagged(); 1818 from = Representation::Tagged();
1819 } 1819 }
1820 // Only mark conversions that might need to allocate as calling rather than 1820 // Only mark conversions that might need to allocate as calling rather than
1821 // all changes. This makes simple, non-allocating conversion not have to force 1821 // all changes. This makes simple, non-allocating conversion not have to force
1822 // building a stack frame. 1822 // building a stack frame.
1823 if (from.IsTagged()) { 1823 if (from.IsTagged()) {
1824 if (to.IsDouble()) { 1824 if (to.IsDouble()) {
1825 info()->MarkAsDeferredCalling();
1826 LOperand* value = UseRegister(instr->value()); 1825 LOperand* value = UseRegister(instr->value());
1827 LNumberUntagD* res = new(zone()) LNumberUntagD(value); 1826 LNumberUntagD* res = new(zone()) LNumberUntagD(value);
1828 return AssignEnvironment(DefineAsRegister(res)); 1827 return AssignEnvironment(DefineAsRegister(res));
1829 } else if (to.IsSmi()) { 1828 } else if (to.IsSmi()) {
1830 HValue* val = instr->value(); 1829 HValue* val = instr->value();
1831 LOperand* value = UseRegister(val); 1830 LOperand* value = UseRegister(val);
1832 if (val->type().IsSmi()) { 1831 if (val->type().IsSmi()) {
1833 return DefineSameAsFirst(new(zone()) LDummyUse(value)); 1832 return DefineSameAsFirst(new(zone()) LDummyUse(value));
1834 } 1833 }
1835 return AssignEnvironment(DefineSameAsFirst(new(zone()) LCheckSmi(value))); 1834 return AssignEnvironment(DefineSameAsFirst(new(zone()) LCheckSmi(value)));
(...skipping 696 matching lines...) Expand 10 before | Expand all | Expand 10 after
2532 LInstruction* LChunkBuilder::DoLoadFieldByIndex(HLoadFieldByIndex* instr) { 2531 LInstruction* LChunkBuilder::DoLoadFieldByIndex(HLoadFieldByIndex* instr) {
2533 LOperand* object = UseRegister(instr->object()); 2532 LOperand* object = UseRegister(instr->object());
2534 LOperand* index = UseTempRegister(instr->index()); 2533 LOperand* index = UseTempRegister(instr->index());
2535 return DefineSameAsFirst(new(zone()) LLoadFieldByIndex(object, index)); 2534 return DefineSameAsFirst(new(zone()) LLoadFieldByIndex(object, index));
2536 } 2535 }
2537 2536
2538 2537
2539 } } // namespace v8::internal 2538 } } // namespace v8::internal
2540 2539
2541 #endif // V8_TARGET_ARCH_X64 2540 #endif // V8_TARGET_ARCH_X64
OLDNEW
« no previous file with comments | « src/mips/lithium-mips.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698