Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(260)

Side by Side Diff: src/mips/lithium-mips.cc

Issue 25373003: Remove unnecessary MarkAsDeferredCalling when changing a tagged value to double (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 7 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/ia32/lithium-ia32.cc ('k') | src/x64/lithium-x64.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 1826 matching lines...) Expand 10 before | Expand all | Expand 10 after
1837 Representation to = instr->to(); 1837 Representation to = instr->to();
1838 if (from.IsSmi()) { 1838 if (from.IsSmi()) {
1839 if (to.IsTagged()) { 1839 if (to.IsTagged()) {
1840 LOperand* value = UseRegister(instr->value()); 1840 LOperand* value = UseRegister(instr->value());
1841 return DefineSameAsFirst(new(zone()) LDummyUse(value)); 1841 return DefineSameAsFirst(new(zone()) LDummyUse(value));
1842 } 1842 }
1843 from = Representation::Tagged(); 1843 from = Representation::Tagged();
1844 } 1844 }
1845 if (from.IsTagged()) { 1845 if (from.IsTagged()) {
1846 if (to.IsDouble()) { 1846 if (to.IsDouble()) {
1847 info()->MarkAsDeferredCalling();
1848 LOperand* value = UseRegister(instr->value()); 1847 LOperand* value = UseRegister(instr->value());
1849 LNumberUntagD* res = new(zone()) LNumberUntagD(value); 1848 LNumberUntagD* res = new(zone()) LNumberUntagD(value);
1850 return AssignEnvironment(DefineAsRegister(res)); 1849 return AssignEnvironment(DefineAsRegister(res));
1851 } else if (to.IsSmi()) { 1850 } else if (to.IsSmi()) {
1852 HValue* val = instr->value(); 1851 HValue* val = instr->value();
1853 LOperand* value = UseRegister(val); 1852 LOperand* value = UseRegister(val);
1854 if (val->type().IsSmi()) { 1853 if (val->type().IsSmi()) {
1855 return DefineSameAsFirst(new(zone()) LDummyUse(value)); 1854 return DefineSameAsFirst(new(zone()) LDummyUse(value));
1856 } 1855 }
1857 return AssignEnvironment(DefineSameAsFirst(new(zone()) LCheckSmi(value))); 1856 return AssignEnvironment(DefineSameAsFirst(new(zone()) LCheckSmi(value)));
(...skipping 673 matching lines...) Expand 10 before | Expand all | Expand 10 after
2531 2530
2532 2531
2533 LInstruction* LChunkBuilder::DoLoadFieldByIndex(HLoadFieldByIndex* instr) { 2532 LInstruction* LChunkBuilder::DoLoadFieldByIndex(HLoadFieldByIndex* instr) {
2534 LOperand* object = UseRegister(instr->object()); 2533 LOperand* object = UseRegister(instr->object());
2535 LOperand* index = UseRegister(instr->index()); 2534 LOperand* index = UseRegister(instr->index());
2536 return DefineAsRegister(new(zone()) LLoadFieldByIndex(object, index)); 2535 return DefineAsRegister(new(zone()) LLoadFieldByIndex(object, index));
2537 } 2536 }
2538 2537
2539 2538
2540 } } // namespace v8::internal 2539 } } // namespace v8::internal
OLDNEW
« no previous file with comments | « src/ia32/lithium-ia32.cc ('k') | src/x64/lithium-x64.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698