Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(243)

Side by Side Diff: src/ia32/lithium-ia32.cc

Issue 25373003: Remove unnecessary MarkAsDeferredCalling when changing a tagged value to double (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 7 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/arm/lithium-arm.cc ('k') | src/mips/lithium-mips.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 1908 matching lines...) Expand 10 before | Expand all | Expand 10 after
1919 LOperand* value = UseRegister(instr->value()); 1919 LOperand* value = UseRegister(instr->value());
1920 return DefineSameAsFirst(new(zone()) LDummyUse(value)); 1920 return DefineSameAsFirst(new(zone()) LDummyUse(value));
1921 } 1921 }
1922 from = Representation::Tagged(); 1922 from = Representation::Tagged();
1923 } 1923 }
1924 // Only mark conversions that might need to allocate as calling rather than 1924 // Only mark conversions that might need to allocate as calling rather than
1925 // all changes. This makes simple, non-allocating conversion not have to force 1925 // all changes. This makes simple, non-allocating conversion not have to force
1926 // building a stack frame. 1926 // building a stack frame.
1927 if (from.IsTagged()) { 1927 if (from.IsTagged()) {
1928 if (to.IsDouble()) { 1928 if (to.IsDouble()) {
1929 info()->MarkAsDeferredCalling();
1930 LOperand* value = UseRegister(instr->value()); 1929 LOperand* value = UseRegister(instr->value());
1931 // Temp register only necessary for minus zero check. 1930 // Temp register only necessary for minus zero check.
1932 LOperand* temp = TempRegister(); 1931 LOperand* temp = TempRegister();
1933 LNumberUntagD* res = new(zone()) LNumberUntagD(value, temp); 1932 LNumberUntagD* res = new(zone()) LNumberUntagD(value, temp);
1934 return AssignEnvironment(DefineAsRegister(res)); 1933 return AssignEnvironment(DefineAsRegister(res));
1935 } else if (to.IsSmi()) { 1934 } else if (to.IsSmi()) {
1936 HValue* val = instr->value(); 1935 HValue* val = instr->value();
1937 LOperand* value = UseRegister(val); 1936 LOperand* value = UseRegister(val);
1938 if (val->type().IsSmi()) { 1937 if (val->type().IsSmi()) {
1939 return DefineSameAsFirst(new(zone()) LDummyUse(value)); 1938 return DefineSameAsFirst(new(zone()) LDummyUse(value));
(...skipping 787 matching lines...) Expand 10 before | Expand all | Expand 10 after
2727 LInstruction* LChunkBuilder::DoLoadFieldByIndex(HLoadFieldByIndex* instr) { 2726 LInstruction* LChunkBuilder::DoLoadFieldByIndex(HLoadFieldByIndex* instr) {
2728 LOperand* object = UseRegister(instr->object()); 2727 LOperand* object = UseRegister(instr->object());
2729 LOperand* index = UseTempRegister(instr->index()); 2728 LOperand* index = UseTempRegister(instr->index());
2730 return DefineSameAsFirst(new(zone()) LLoadFieldByIndex(object, index)); 2729 return DefineSameAsFirst(new(zone()) LLoadFieldByIndex(object, index));
2731 } 2730 }
2732 2731
2733 2732
2734 } } // namespace v8::internal 2733 } } // namespace v8::internal
2735 2734
2736 #endif // V8_TARGET_ARCH_IA32 2735 #endif // V8_TARGET_ARCH_IA32
OLDNEW
« no previous file with comments | « src/arm/lithium-arm.cc ('k') | src/mips/lithium-mips.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698