Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(77)

Side by Side Diff: src/arm/lithium-arm.cc

Issue 25373003: Remove unnecessary MarkAsDeferredCalling when changing a tagged value to double (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 7 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | src/ia32/lithium-ia32.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 1926 matching lines...) Expand 10 before | Expand all | Expand 10 after
1937 Representation to = instr->to(); 1937 Representation to = instr->to();
1938 if (from.IsSmi()) { 1938 if (from.IsSmi()) {
1939 if (to.IsTagged()) { 1939 if (to.IsTagged()) {
1940 LOperand* value = UseRegister(instr->value()); 1940 LOperand* value = UseRegister(instr->value());
1941 return DefineSameAsFirst(new(zone()) LDummyUse(value)); 1941 return DefineSameAsFirst(new(zone()) LDummyUse(value));
1942 } 1942 }
1943 from = Representation::Tagged(); 1943 from = Representation::Tagged();
1944 } 1944 }
1945 if (from.IsTagged()) { 1945 if (from.IsTagged()) {
1946 if (to.IsDouble()) { 1946 if (to.IsDouble()) {
1947 info()->MarkAsDeferredCalling();
1948 LOperand* value = UseRegister(instr->value()); 1947 LOperand* value = UseRegister(instr->value());
1949 LNumberUntagD* res = new(zone()) LNumberUntagD(value); 1948 LNumberUntagD* res = new(zone()) LNumberUntagD(value);
1950 return AssignEnvironment(DefineAsRegister(res)); 1949 return AssignEnvironment(DefineAsRegister(res));
1951 } else if (to.IsSmi()) { 1950 } else if (to.IsSmi()) {
1952 HValue* val = instr->value(); 1951 HValue* val = instr->value();
1953 LOperand* value = UseRegister(val); 1952 LOperand* value = UseRegister(val);
1954 if (val->type().IsSmi()) { 1953 if (val->type().IsSmi()) {
1955 return DefineSameAsFirst(new(zone()) LDummyUse(value)); 1954 return DefineSameAsFirst(new(zone()) LDummyUse(value));
1956 } 1955 }
1957 return AssignEnvironment(DefineSameAsFirst(new(zone()) LCheckSmi(value))); 1956 return AssignEnvironment(DefineSameAsFirst(new(zone()) LCheckSmi(value)));
(...skipping 701 matching lines...) Expand 10 before | Expand all | Expand 10 after
2659 2658
2660 2659
2661 LInstruction* LChunkBuilder::DoLoadFieldByIndex(HLoadFieldByIndex* instr) { 2660 LInstruction* LChunkBuilder::DoLoadFieldByIndex(HLoadFieldByIndex* instr) {
2662 LOperand* object = UseRegister(instr->object()); 2661 LOperand* object = UseRegister(instr->object());
2663 LOperand* index = UseRegister(instr->index()); 2662 LOperand* index = UseRegister(instr->index());
2664 return DefineAsRegister(new(zone()) LLoadFieldByIndex(object, index)); 2663 return DefineAsRegister(new(zone()) LLoadFieldByIndex(object, index));
2665 } 2664 }
2666 2665
2667 2666
2668 } } // namespace v8::internal 2667 } } // namespace v8::internal
OLDNEW
« no previous file with comments | « no previous file | src/ia32/lithium-ia32.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698