Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(868)

Unified Diff: chrome/browser/extensions/extension_action_icon_factory.cc

Issue 2537263003: [Extensions] Fix lifetime bug in ExtensionAction/IconImage (Closed)
Patch Set: Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/extension_action_icon_factory.cc
diff --git a/chrome/browser/extensions/extension_action_icon_factory.cc b/chrome/browser/extensions/extension_action_icon_factory.cc
index 4b72500939a93b1208dd675f54e9c9d106016069..f389230d11aee7f8251bce31f501317fe0abc370 100644
--- a/chrome/browser/extensions/extension_action_icon_factory.cc
+++ b/chrome/browser/extensions/extension_action_icon_factory.cc
@@ -18,10 +18,8 @@ ExtensionActionIconFactory::ExtensionActionIconFactory(
ExtensionAction* action,
Observer* observer)
: action_(action), observer_(observer), icon_image_observer_(this) {
- extensions::IconImage* default_icon_image =
- action->LoadDefaultIconImage(*extension, profile);
- if (default_icon_image)
- icon_image_observer_.Add(default_icon_image);
+ if (action->default_icon_image())
+ icon_image_observer_.Add(action->default_icon_image());
}
ExtensionActionIconFactory::~ExtensionActionIconFactory() {}
« no previous file with comments | « chrome/browser/extensions/extension_action.cc ('k') | chrome/browser/extensions/extension_action_icon_factory_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698