Side by Side Diff
Use n/p to move between diff chunks; N/P to move between comments.
Draft comments are only viewable by you.
Keyboard Shortcuts
File
u
:
up to issue
j
/
k
:
jump to file after / before current file
J
/
K
:
jump to next file with a comment after / before current file
Side-by-side diff
i
:
toggle intra-line diffs
e
:
expand all comments
c
:
collapse all comments
s
:
toggle showing all comments
n
/
p
:
next / previous diff chunk or comment
N
/
P
:
next / previous comment
<Up>
/
<Down>
:
next / previous line
Issue
u
:
up to list of issues
j
/
k
:
jump to patch after / before current patch
o
/
<Enter>
:
open current patch in side-by-side view
i
:
open current patch in unified diff view
Issue List
j
/
k
:
jump to issue after / before current issue
o
/
<Enter>
:
open current issue
Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr)
|
Please choose your nickname with
Settings
|
Help
|
Chromium Project
|
Gerrit Changes
|
Sign out
(333)
Issues
Search
My Issues
|
Starred
Open
|
Closed
|
All
Side by Side Diff: chrome/test/data/extensions/api_test/browser_action_with_icon/icon.png
Issue
2537263003
:
[Extensions] Fix lifetime bug in ExtensionAction/IconImage (Closed)
Patch Set:
Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments.
Draft comments are only viewable by you.
Context:
3 lines
10 lines
25 lines
50 lines
75 lines
100 lines
Whole file
Column Width:
Tab Spaces:
Jump to:
chrome/browser/extensions/extension_action.h
chrome/browser/extensions/extension_action.cc
chrome/browser/extensions/extension_action_icon_factory.cc
chrome/browser/extensions/extension_action_icon_factory_unittest.cc
chrome/browser/extensions/extension_action_manager.cc
chrome/browser/extensions/extension_browsertest.cc
chrome/browser/ui/toolbar/browser_actions_bar_browsertest.cc
chrome/test/data/extensions/api_test/browser_action_with_icon/icon.png
chrome/test/data/extensions/api_test/browser_action_with_icon/manifest.json
View unified diff
|
Download patch
« no previous file with comments
|
« chrome/browser/ui/toolbar/browser_actions_bar_browsertest.cc
('k') |
chrome/test/data/extensions/api_test/browser_action_with_icon/manifest.json »
('j') |
no next file with comments »
Toggle Intra-line Diffs
('i') |
Expand Comments
('e') |
Collapse Comments
('c') |
Show Comments
Hide Comments
('s')
OLD
NEW
OLD
NEW
« no previous file with comments
|
« chrome/browser/ui/toolbar/browser_actions_bar_browsertest.cc
('k') |
chrome/test/data/extensions/api_test/browser_action_with_icon/manifest.json »
('j') |
no next file with comments »
Issue 2537263003: [Extensions] Fix lifetime bug in ExtensionAction/IconImage (Closed)
Created 4 years ago by Devlin
Modified 4 years ago
Reviewers:
Base URL:
Comments: 0
This is Rietveld
408576698
Chromium Code Reviews
Issue 2537263003:
[Extensions] Fix lifetime bug in ExtensionAction/IconImage (Closed)
