Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(159)

Issue 2537253003: [js-perf-test] Move SubRegExp class definition outside loop (Closed)

Created:
4 years ago by jgruber
Modified:
4 years ago
Reviewers:
Camillo Bruni
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[js-perf-test] Move SubRegExp class definition outside loop Defining the subclass within the loop significantly affects subsequent test results. For instance, the Search benchmark is 50% slower if the subclass is defined within the loop. BUG=v8:5339 Committed: https://crrev.com/2f17d5f8e84521140ebd3703e7bb73ef94fc2495 Cr-Commit-Position: refs/heads/master@{#41384}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -4 lines) Patch
M test/js-perf-test/RegExp/base_ctor.js View 1 chunk +5 lines, -4 lines 0 comments Download

Messages

Total messages: 15 (10 generated)
jgruber
4 years ago (2016-11-30 10:23:40 UTC) #4
Camillo Bruni
lgtm
4 years ago (2016-11-30 12:07:57 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2537253003/1
4 years ago (2016-11-30 12:18:25 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-11-30 12:20:03 UTC) #13
commit-bot: I haz the power
4 years ago (2016-11-30 12:20:29 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/2f17d5f8e84521140ebd3703e7bb73ef94fc2495
Cr-Commit-Position: refs/heads/master@{#41384}

Powered by Google App Engine
This is Rietveld 408576698