Fixed assert causing crash when attempting to load a library from an invalid path.

Fixed the conditions of an assert causing the debug VM to crash when trying to load a library from an invalid path. Created copy of a previous deferred_import_t02.dart test from co19 as a regression test until deferred_import_t02.dart is reverted to the previous test.

Fixes #27201

R=zra@google.com

Committed: https://github.com/dart-lang/sdk/commit/7e918f5b4807e977234a111386de3e431b627b5d

[bkonyi, 2016-11-29 21:13:08]

Description was changed from

==========
Fixed assert causing crash when attempting to load a library from an invalid
path.

Fixed the conditions of an assert causing the debug VM to crash when tryping to
load a library from an invalid path. Created copy of a previous
deferred_import_t02.dart test from co19 as a regression test.

BUG=27201
==========

to

==========
Fixed the conditions of an assert causing the debug VM to crash when trying to
load a library from an invalid path. Created copy of a previous
deferred_import_t02.dart test from co19 as a regression test until
deferred_import_t02.dart is reverted to the previous test.

BUG=
==========

[bkonyi, 2016-11-29 21:13:29]

Description was changed from

==========
Fixed the conditions of an assert causing the debug VM to crash when trying to
load a library from an invalid path. Created copy of a previous
deferred_import_t02.dart test from co19 as a regression test until
deferred_import_t02.dart is reverted to the previous test.

BUG=
==========

to

==========
Fixed the conditions of an assert causing the debug VM to crash when trying to
load a library from an invalid path. Created copy of a previous
deferred_import_t02.dart test from co19 as a regression test until
deferred_import_t02.dart is reverted to the previous test.

BUG=https://github.com/dart-lang/sdk/issues/27201
==========

[bkonyi, 2016-11-29 21:15:48]

bkonyi@google.com changed reviewers:
+ asiva@google.com, zra@google.com

[zra, 2016-11-29 21:24:35]

I think BUG=... isn't understood by github, but if you write

fixes #<issue number>

in the issue github will do the right thing.

https://codereview.chromium.org/2537253002/diff/1/tests/language/vm/regress_2...
File tests/language/vm/regress_27201_lib.dart (right):

https://codereview.chromium.org/2537253002/diff/1/tests/language/vm/regress_2...
tests/language/vm/regress_27201_lib.dart:1: // Copyright (c) 2015, the Dart
project authors.  Please see the AUTHORS file
2016

https://codereview.chromium.org/2537253002/diff/1/tests/language/vm/regress_2...
File tests/language/vm/regress_27201_test.dart (right):

https://codereview.chromium.org/2537253002/diff/1/tests/language/vm/regress_2...
tests/language/vm/regress_27201_test.dart:2: * Copyright (c) 2011, the Dart
project authors.  Please see the AUTHORS file
2016

https://codereview.chromium.org/2537253002/diff/1/tests/language/vm/regress_2...
tests/language/vm/regress_27201_test.dart:6: /**
We probably don't need to copy this comment from the co19 test.

https://codereview.chromium.org/2537253002/diff/1/tests/language/vm/regress_2...
tests/language/vm/regress_27201_test.dart:64: import
"../../co19/src/Utils/expect.dart";
Let's not have a dependence on co19 here. Use:

import "package:expect/expect.dart"

instead.

https://codereview.chromium.org/2537253002/diff/1/tests/language/vm/regress_2...
tests/language/vm/regress_27201_test.dart:97: main() async {
There is no await, so async is not needed.

https://codereview.chromium.org/2537253002/diff/1/tests/language/vm/regress_2...
tests/language/vm/regress_27201_test.dart:105: // Ensure bad library import is
handled correctly
Please end comments with a '.'

[bkonyi, 2016-11-29 21:35:10]

Description was changed from

==========
Fixed the conditions of an assert causing the debug VM to crash when trying to
load a library from an invalid path. Created copy of a previous
deferred_import_t02.dart test from co19 as a regression test until
deferred_import_t02.dart is reverted to the previous test.

BUG=https://github.com/dart-lang/sdk/issues/27201
==========

to

==========
Fixed the conditions of an assert causing the debug VM to crash when trying to
load a library from an invalid path. Created copy of a previous
deferred_import_t02.dart test from co19 as a regression test until
deferred_import_t02.dart is reverted to the previous test.

Fixes #27201
==========

[bkonyi, 2016-11-29 21:37:35]

On 2016/11/29 21:24:35, zra wrote:
> I think BUG=... isn't understood by github, but if you write
> 
> fixes #<issue number>
> 
> in the issue github will do the right thing.
> 
>
https://codereview.chromium.org/2537253002/diff/1/tests/language/vm/regress_2...
> File tests/language/vm/regress_27201_lib.dart (right):
> 
>
https://codereview.chromium.org/2537253002/diff/1/tests/language/vm/regress_2...
> tests/language/vm/regress_27201_lib.dart:1: // Copyright (c) 2015, the Dart
> project authors.  Please see the AUTHORS file
> 2016
> 
>
https://codereview.chromium.org/2537253002/diff/1/tests/language/vm/regress_2...
> File tests/language/vm/regress_27201_test.dart (right):
> 
>
https://codereview.chromium.org/2537253002/diff/1/tests/language/vm/regress_2...
> tests/language/vm/regress_27201_test.dart:2: * Copyright (c) 2011, the Dart
> project authors.  Please see the AUTHORS file
> 2016
> 
>
https://codereview.chromium.org/2537253002/diff/1/tests/language/vm/regress_2...
> tests/language/vm/regress_27201_test.dart:6: /**
> We probably don't need to copy this comment from the co19 test.
> 
>
https://codereview.chromium.org/2537253002/diff/1/tests/language/vm/regress_2...
> tests/language/vm/regress_27201_test.dart:64: import
> "../../co19/src/Utils/expect.dart";
> Let's not have a dependence on co19 here. Use:
> 
> import "package:expect/expect.dart"
> 
> instead.
> 
>
https://codereview.chromium.org/2537253002/diff/1/tests/language/vm/regress_2...
> tests/language/vm/regress_27201_test.dart:97: main() async {
> There is no await, so async is not needed.
> 
>
https://codereview.chromium.org/2537253002/diff/1/tests/language/vm/regress_2...
> tests/language/vm/regress_27201_test.dart:105: // Ensure bad library import is
> handled correctly
> Please end comments with a '.'

I've gone ahead and added the fixes #27201 in the commit message and
description. Should that do it?

[bkonyi, 2016-11-29 21:43:17]

https://codereview.chromium.org/2537253002/diff/1/tests/language/vm/regress_2...
File tests/language/vm/regress_27201_lib.dart (right):

https://codereview.chromium.org/2537253002/diff/1/tests/language/vm/regress_2...
tests/language/vm/regress_27201_lib.dart:1: // Copyright (c) 2015, the Dart
project authors.  Please see the AUTHORS file
On 2016/11/29 21:24:35, zra wrote:
> 2016

Done.

https://codereview.chromium.org/2537253002/diff/1/tests/language/vm/regress_2...
File tests/language/vm/regress_27201_test.dart (right):

https://codereview.chromium.org/2537253002/diff/1/tests/language/vm/regress_2...
tests/language/vm/regress_27201_test.dart:2: * Copyright (c) 2011, the Dart
project authors.  Please see the AUTHORS file
On 2016/11/29 21:24:35, zra wrote:
> 2016

Done.

https://codereview.chromium.org/2537253002/diff/1/tests/language/vm/regress_2...
tests/language/vm/regress_27201_test.dart:6: /**
On 2016/11/29 21:24:35, zra wrote:
> We probably don't need to copy this comment from the co19 test.

Done.

https://codereview.chromium.org/2537253002/diff/1/tests/language/vm/regress_2...
tests/language/vm/regress_27201_test.dart:64: import
"../../co19/src/Utils/expect.dart";
On 2016/11/29 21:24:35, zra wrote:
> Let's not have a dependence on co19 here. Use:
> 
> import "package:expect/expect.dart"
> 
> instead.

Done.

https://codereview.chromium.org/2537253002/diff/1/tests/language/vm/regress_2...
tests/language/vm/regress_27201_test.dart:97: main() async {
On 2016/11/29 21:24:35, zra wrote:
> There is no await, so async is not needed.

Done.

https://codereview.chromium.org/2537253002/diff/1/tests/language/vm/regress_2...
tests/language/vm/regress_27201_test.dart:105: // Ensure bad library import is
handled correctly
On 2016/11/29 21:24:35, zra wrote:
> Please end comments with a '.'

Done.

[zra, 2016-11-29 21:44:53]

lgtm

[bkonyi, 2016-11-29 22:07:28]

Description was changed from

==========
Fixed the conditions of an assert causing the debug VM to crash when trying to
load a library from an invalid path. Created copy of a previous
deferred_import_t02.dart test from co19 as a regression test until
deferred_import_t02.dart is reverted to the previous test.

Fixes #27201
==========

to

==========
Fixed the conditions of an assert causing the debug VM to crash when trying to
load a library from an invalid path. Created copy of a previous
deferred_import_t02.dart test from co19 as a regression test until
deferred_import_t02.dart is reverted to the previous test.

Fixes #27201

R=zra@google.com

Committed:
https://github.com/dart-lang/sdk/commit/7e918f5b4807e977234a111386de3e431b627b5d
==========

[bkonyi, 2016-11-29 22:07:29]

Committed patchset #2 (id:20001) manually as
7e918f5b4807e977234a111386de3e431b627b5d (presubmit successful).