third_party/WebKit/Source/core/editing/SelectionController.cpp - Issue 2537243002: Adding |Node::layoutObject()| null check to |setCaretAtHitTestResult()|

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/editing/SelectionController.cpp

Issue 2537243002: Adding |Node::layoutObject()| null check to |setCaretAtHitTestResult()| (Closed)

Patch Set: pulling hitTest sanity check out of selection controller Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/editing/SelectionController.cpp

diff --git a/third_party/WebKit/Source/core/editing/SelectionController.cpp b/third_party/WebKit/Source/core/editing/SelectionController.cpp

index a38381e9c24ff9ec7cdfc6856a1c536d1eb71c1c..566b973ec53c575209479bc98b3f355d8554d464 100644

--- a/third_party/WebKit/Source/core/editing/SelectionController.cpp

+++ b/third_party/WebKit/Source/core/editing/SelectionController.cpp

@@ -652,9 +652,6 @@ void SelectionController::setNonDirectionalSelectionIfNeeded(

void SelectionController::setCaretAtHitTestResult(

const HitTestResult& hitTestResult) {

Node* innerNode = hitTestResult.innerNode();

- if (!innerNode)

- return;

const VisiblePositionInFlatTree& visibleHitPos =

visiblePositionOfHitTestResult(hitTestResult);

const VisiblePositionInFlatTree& visiblePos =

@@ -892,8 +889,6 @@ bool SelectionController::handleGestureLongPress(

return false;

Node* innerNode = hitTestResult.innerNode();

- if (!innerNode)

- return false;

innerNode->document().updateStyleAndLayoutTree();

bool innerNodeIsSelectable = hasEditableStyle(*innerNode) ||

innerNode->isTextNode() ||

« no previous file with comments | « no previous file | third_party/WebKit/Source/core/input/GestureManager.cpp » ('j') | no next file with comments »