Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(99)

Side by Side Diff: third_party/WebKit/Source/devtools/front_end/persistence/Persistence.js

Issue 2537233003: DevTools: [Persistence] sync working copies of UISourceCodes (Closed)
Patch Set: address comments Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 /** 4 /**
5 * @unrestricted 5 * @unrestricted
6 */ 6 */
7 Persistence.Persistence = class extends Common.Object { 7 Persistence.Persistence = class extends Common.Object {
8 /** 8 /**
9 * @param {!Workspace.Workspace} workspace 9 * @param {!Workspace.Workspace} workspace
10 * @param {!Bindings.BreakpointManager} breakpointManager 10 * @param {!Bindings.BreakpointManager} breakpointManager
(...skipping 31 matching lines...) Expand 10 before | Expand all | Expand 10 after
42 42
43 binding.network[Persistence.Persistence._binding] = binding; 43 binding.network[Persistence.Persistence._binding] = binding;
44 binding.fileSystem[Persistence.Persistence._binding] = binding; 44 binding.fileSystem[Persistence.Persistence._binding] = binding;
45 45
46 binding.fileSystem.forceLoadOnCheckContent(); 46 binding.fileSystem.forceLoadOnCheckContent();
47 47
48 binding.network.addEventListener( 48 binding.network.addEventListener(
49 Workspace.UISourceCode.Events.WorkingCopyCommitted, this._onWorkingCopyC ommitted, this); 49 Workspace.UISourceCode.Events.WorkingCopyCommitted, this._onWorkingCopyC ommitted, this);
50 binding.fileSystem.addEventListener( 50 binding.fileSystem.addEventListener(
51 Workspace.UISourceCode.Events.WorkingCopyCommitted, this._onWorkingCopyC ommitted, this); 51 Workspace.UISourceCode.Events.WorkingCopyCommitted, this._onWorkingCopyC ommitted, this);
52 binding.network.addEventListener(
53 Workspace.UISourceCode.Events.WorkingCopyChanged, this._onWorkingCopyCha nged, this);
54 binding.fileSystem.addEventListener(
55 Workspace.UISourceCode.Events.WorkingCopyChanged, this._onWorkingCopyCha nged, this);
52 56
53 this._addFilePathBindingPrefixes(binding.fileSystem.url()); 57 this._addFilePathBindingPrefixes(binding.fileSystem.url());
54 58
55 this._moveBreakpoints(binding.fileSystem, binding.network); 59 this._moveBreakpoints(binding.fileSystem, binding.network);
56 this.dispatchEventToListeners(Persistence.Persistence.Events.BindingCreated, binding); 60 this.dispatchEventToListeners(Persistence.Persistence.Events.BindingCreated, binding);
57 } 61 }
58 62
59 /** 63 /**
60 * @param {!Persistence.PersistenceBinding} binding 64 * @param {!Persistence.PersistenceBinding} binding
61 */ 65 */
62 _onBindingRemoved(binding) { 66 _onBindingRemoved(binding) {
63 if (binding.network.isDirty())
64 binding.fileSystem.setWorkingCopy(binding.network.workingCopy());
65
66 binding.network[Persistence.Persistence._binding] = null; 67 binding.network[Persistence.Persistence._binding] = null;
67 binding.fileSystem[Persistence.Persistence._binding] = null; 68 binding.fileSystem[Persistence.Persistence._binding] = null;
68 69
69 binding.network.removeEventListener( 70 binding.network.removeEventListener(
70 Workspace.UISourceCode.Events.WorkingCopyCommitted, this._onWorkingCopyC ommitted, this); 71 Workspace.UISourceCode.Events.WorkingCopyCommitted, this._onWorkingCopyC ommitted, this);
71 binding.fileSystem.removeEventListener( 72 binding.fileSystem.removeEventListener(
72 Workspace.UISourceCode.Events.WorkingCopyCommitted, this._onWorkingCopyC ommitted, this); 73 Workspace.UISourceCode.Events.WorkingCopyCommitted, this._onWorkingCopyC ommitted, this);
74 binding.network.removeEventListener(
75 Workspace.UISourceCode.Events.WorkingCopyChanged, this._onWorkingCopyCha nged, this);
76 binding.fileSystem.removeEventListener(
77 Workspace.UISourceCode.Events.WorkingCopyChanged, this._onWorkingCopyCha nged, this);
73 78
74 this._removeFilePathBindingPrefixes(binding.fileSystem.url()); 79 this._removeFilePathBindingPrefixes(binding.fileSystem.url());
75 80
76 this._breakpointManager.copyBreakpoints(binding.network.url(), binding.fileS ystem); 81 this._breakpointManager.copyBreakpoints(binding.network.url(), binding.fileS ystem);
77 this.dispatchEventToListeners(Persistence.Persistence.Events.BindingRemoved, binding); 82 this.dispatchEventToListeners(Persistence.Persistence.Events.BindingRemoved, binding);
78 } 83 }
79 84
80 /** 85 /**
81 * @param {!Common.Event} event 86 * @param {!Common.Event} event
82 */ 87 */
88 _onWorkingCopyChanged(event) {
89 var uiSourceCode = /** @type {!Workspace.UISourceCode} */ (event.target);
90 var binding = uiSourceCode[Persistence.Persistence._binding];
91 if (!binding || binding[Persistence.Persistence._muteWorkingCopy])
92 return;
93 var other = binding.network === uiSourceCode ? binding.fileSystem : binding. network;
94 var target = Bindings.NetworkProject.targetForUISourceCode(binding.network);
95 if (target.isNodeJS()) {
96 var newContent = uiSourceCode.workingCopy();
97 other.requestContent().then(() => {
98 var nodeJSContent = this._rewrapNodeJSContent(binding, other, other.work ingCopy(), newContent);
99 setWorkingCopy.call(this, () => nodeJSContent);
100 });
101 return;
102 }
103
104 setWorkingCopy.call(this, () => uiSourceCode.workingCopy());
105
106 /**
107 * @param {function():string} workingCopyGetter
108 * @this {Persistence.Persistence}
109 */
110 function setWorkingCopy(workingCopyGetter) {
111 binding[Persistence.Persistence._muteWorkingCopy] = true;
112 other.setWorkingCopyGetter(workingCopyGetter);
113 binding[Persistence.Persistence._muteWorkingCopy] = false;
114 this._contentSyncedForTest();
115 }
116 }
117
118 /**
119 * @param {!Common.Event} event
120 */
83 _onWorkingCopyCommitted(event) { 121 _onWorkingCopyCommitted(event) {
84 var uiSourceCode = /** @type {!Workspace.UISourceCode} */ (event.target); 122 var uiSourceCode = /** @type {!Workspace.UISourceCode} */ (event.target);
85 var binding = uiSourceCode[Persistence.Persistence._binding]; 123 var binding = uiSourceCode[Persistence.Persistence._binding];
86 if (!binding || binding[Persistence.Persistence._muteCommit]) 124 if (!binding || binding[Persistence.Persistence._muteCommit])
87 return; 125 return;
88 var newContent = /** @type {string} */ (event.data.content); 126 var newContent = /** @type {string} */ (event.data.content);
89 var other = binding.network === uiSourceCode ? binding.fileSystem : binding. network; 127 var other = binding.network === uiSourceCode ? binding.fileSystem : binding. network;
90 var target = Bindings.NetworkProject.targetForUISourceCode(binding.network); 128 var target = Bindings.NetworkProject.targetForUISourceCode(binding.network);
91 if (target.isNodeJS()) { 129 if (target.isNodeJS()) {
92 other.requestContent().then( 130 other.requestContent().then(currentContent => {
93 currentContent => this._syncNodeJSContent(binding, other, currentConte nt, newContent)); 131 var nodeJSContent = this._rewrapNodeJSContent(binding, other, currentCon tent, newContent);
132 setContent.call(this, nodeJSContent);
133 });
94 return; 134 return;
95 } 135 }
96 binding[Persistence.Persistence._muteCommit] = true; 136 setContent.call(this, newContent);
97 other.addRevision(newContent); 137
98 binding[Persistence.Persistence._muteCommit] = false; 138 /**
99 this._contentSyncedForTest(); 139 * @param {string} newContent
140 * @this {Persistence.Persistence}
141 */
142 function setContent(newContent) {
143 binding[Persistence.Persistence._muteCommit] = true;
144 other.addRevision(newContent);
145 binding[Persistence.Persistence._muteCommit] = false;
146 this._contentSyncedForTest();
147 }
100 } 148 }
101 149
102 /** 150 /**
103 * @param {!Persistence.PersistenceBinding} binding 151 * @param {!Persistence.PersistenceBinding} binding
104 * @param {!Workspace.UISourceCode} uiSourceCode 152 * @param {!Workspace.UISourceCode} uiSourceCode
105 * @param {string} currentContent 153 * @param {string} currentContent
106 * @param {string} newContent 154 * @param {string} newContent
155 * @return {string}
107 */ 156 */
108 _syncNodeJSContent(binding, uiSourceCode, currentContent, newContent) { 157 _rewrapNodeJSContent(binding, uiSourceCode, currentContent, newContent) {
109 if (uiSourceCode === binding.fileSystem) { 158 if (uiSourceCode === binding.fileSystem) {
110 if (newContent.startsWith(Persistence.Persistence._NodePrefix) && 159 if (newContent.startsWith(Persistence.Persistence._NodePrefix) &&
111 newContent.endsWith(Persistence.Persistence._NodeSuffix)) { 160 newContent.endsWith(Persistence.Persistence._NodeSuffix)) {
112 newContent = newContent.substring( 161 newContent = newContent.substring(
113 Persistence.Persistence._NodePrefix.length, newContent.length - Pers istence.Persistence._NodeSuffix.length); 162 Persistence.Persistence._NodePrefix.length, newContent.length - Pers istence.Persistence._NodeSuffix.length);
114 } 163 }
115 if (currentContent.startsWith(Persistence.Persistence._NodeShebang)) 164 if (currentContent.startsWith(Persistence.Persistence._NodeShebang))
116 newContent = Persistence.Persistence._NodeShebang + newContent; 165 newContent = Persistence.Persistence._NodeShebang + newContent;
117 } else { 166 } else {
118 if (newContent.startsWith(Persistence.Persistence._NodeShebang)) 167 if (newContent.startsWith(Persistence.Persistence._NodeShebang))
119 newContent = newContent.substring(Persistence.Persistence._NodeShebang.l ength); 168 newContent = newContent.substring(Persistence.Persistence._NodeShebang.l ength);
120 if (currentContent.startsWith(Persistence.Persistence._NodePrefix) && 169 if (currentContent.startsWith(Persistence.Persistence._NodePrefix) &&
121 currentContent.endsWith(Persistence.Persistence._NodeSuffix)) 170 currentContent.endsWith(Persistence.Persistence._NodeSuffix))
122 newContent = Persistence.Persistence._NodePrefix + newContent + Persiste nce.Persistence._NodeSuffix; 171 newContent = Persistence.Persistence._NodePrefix + newContent + Persiste nce.Persistence._NodeSuffix;
123 } 172 }
124 binding[Persistence.Persistence._muteCommit] = true; 173 return newContent;
125 uiSourceCode.addRevision(newContent);
126 binding[Persistence.Persistence._muteCommit] = false;
127 this._contentSyncedForTest();
128 } 174 }
129 175
130 _contentSyncedForTest() { 176 _contentSyncedForTest() {
131 } 177 }
132 178
133 /** 179 /**
134 * @param {!Workspace.UISourceCode} from 180 * @param {!Workspace.UISourceCode} from
135 * @param {!Workspace.UISourceCode} to 181 * @param {!Workspace.UISourceCode} to
136 */ 182 */
137 _moveBreakpoints(from, to) { 183 _moveBreakpoints(from, to) {
(...skipping 75 matching lines...) Expand 10 before | Expand all | Expand 10 after
213 return this._filePathPrefixesToBindingCount.has(filePath); 259 return this._filePathPrefixesToBindingCount.has(filePath);
214 } 260 }
215 261
216 dispose() { 262 dispose() {
217 this._mapping.dispose(); 263 this._mapping.dispose();
218 } 264 }
219 }; 265 };
220 266
221 Persistence.Persistence._binding = Symbol('Persistence.Binding'); 267 Persistence.Persistence._binding = Symbol('Persistence.Binding');
222 Persistence.Persistence._muteCommit = Symbol('Persistence.MuteCommit'); 268 Persistence.Persistence._muteCommit = Symbol('Persistence.MuteCommit');
269 Persistence.Persistence._muteWorkingCopy = Symbol('Persistence.MuteWorkingCopy') ;
223 270
224 Persistence.Persistence._NodePrefix = '(function (exports, require, module, __fi lename, __dirname) { '; 271 Persistence.Persistence._NodePrefix = '(function (exports, require, module, __fi lename, __dirname) { ';
225 Persistence.Persistence._NodeSuffix = '\n});'; 272 Persistence.Persistence._NodeSuffix = '\n});';
226 Persistence.Persistence._NodeShebang = '#!/usr/bin/env node'; 273 Persistence.Persistence._NodeShebang = '#!/usr/bin/env node';
227 274
228 Persistence.Persistence.Events = { 275 Persistence.Persistence.Events = {
229 BindingCreated: Symbol('BindingCreated'), 276 BindingCreated: Symbol('BindingCreated'),
230 BindingRemoved: Symbol('BindingRemoved') 277 BindingRemoved: Symbol('BindingRemoved')
231 }; 278 };
232 279
233 /** 280 /**
234 * @unrestricted 281 * @unrestricted
235 */ 282 */
236 Persistence.PersistenceBinding = class { 283 Persistence.PersistenceBinding = class {
237 /** 284 /**
238 * @param {!Workspace.UISourceCode} network 285 * @param {!Workspace.UISourceCode} network
239 * @param {!Workspace.UISourceCode} fileSystem 286 * @param {!Workspace.UISourceCode} fileSystem
240 * @param {boolean} exactMatch 287 * @param {boolean} exactMatch
241 */ 288 */
242 constructor(network, fileSystem, exactMatch) { 289 constructor(network, fileSystem, exactMatch) {
243 this.network = network; 290 this.network = network;
244 this.fileSystem = fileSystem; 291 this.fileSystem = fileSystem;
245 this.exactMatch = exactMatch; 292 this.exactMatch = exactMatch;
246 } 293 }
247 }; 294 };
248 295
249 /** @type {!Persistence.Persistence} */ 296 /** @type {!Persistence.Persistence} */
250 Persistence.persistence; 297 Persistence.persistence;
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698