Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(46)

Unified Diff: components/bookmarks/browser/bookmark_node.h

Issue 2537223008: Add TitledUrlIndex for indexing arbitrary title/URL pairs (Closed)
Patch Set: fix bookmark_bridge Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/bookmarks/browser/bookmark_node.h
diff --git a/components/bookmarks/browser/bookmark_node.h b/components/bookmarks/browser/bookmark_node.h
index 84cea2b07d1467e8b65915181ad7321af70e4345..8825b8b19f65e73486a9c91c1c3bd2e677456cf0 100644
--- a/components/bookmarks/browser/bookmark_node.h
+++ b/components/bookmarks/browser/bookmark_node.h
@@ -12,6 +12,7 @@
#include "base/macros.h"
#include "base/task/cancelable_task_tracker.h"
#include "base/time/time.h"
+#include "components/bookmarks/browser/titled_url_node.h"
#include "components/favicon_base/favicon_types.h"
#include "ui/base/models/tree_node_model.h"
#include "ui/gfx/image/image.h"
@@ -25,7 +26,7 @@ class BookmarkModel;
// BookmarkNode contains information about a starred entry: title, URL, favicon,
// id and type. BookmarkNodes are returned from BookmarkModel.
-class BookmarkNode : public ui::TreeNode<BookmarkNode> {
+class BookmarkNode : public ui::TreeNode<BookmarkNode>, public TitledUrlNode {
public:
enum Type {
URL,
@@ -115,6 +116,11 @@ class BookmarkNode : public ui::TreeNode<BookmarkNode> {
}
int64_t sync_transaction_version() const { return sync_transaction_version_; }
+ // TitledUrlNode interface methods.
+ const base::string16& GetTitledUrlNodeTitle() const override;
+ const GURL& GetTitledUrlNodeUrl() const override;
+ long GetTitledUrlNodeId() const override;
+
// TODO(sky): Consider adding last visit time here, it'll greatly simplify
// HistoryContentsProvider.

Powered by Google App Engine
This is Rietveld 408576698