Add TitledUrlIndex for indexing arbitrary title/URL pairs

chrome/browser/android/bookmarks/bookmark_bridge.cc

Index: chrome/browser/android/bookmarks/bookmark_bridge.cc
diff --git a/chrome/browser/android/bookmarks/bookmark_bridge.cc b/chrome/browser/android/bookmarks/bookmark_bridge.cc
index b91e6c6b3d1f474dabf87f153e71dc7168ff0632..3dc8936f270ab8998930bc8fc45f21d89cd3283b 100644
--- a/chrome/browser/android/bookmarks/bookmark_bridge.cc
+++ b/chrome/browser/android/bookmarks/bookmark_bridge.cc
@@ -593,7 +593,7 @@ void BookmarkBridge::SearchBookmarks(JNIEnv* env,
       query_parser::MatchingAlgorithm::ALWAYS_PREFIX_SEARCH,
       &results);
   for (const bookmarks::BookmarkMatch& match : results) {
-    const BookmarkNode* node = match.node;
+    const TitledUrlNode* node = match.node;
 
     std::vector<int> title_match_start_positions;
     std::vector<int> title_match_end_positions;
@@ -610,7 +610,7 @@ void BookmarkBridge::SearchBookmarks(JNIEnv* env,
     }
 
     Java_BookmarkBridge_addToBookmarkMatchList(
-        env, j_list, node->id(), node->type(),
+        env, j_list, node->GetTitledUrlNodeId(), Type::URL,

[mattreynolds, 2016/12/08 21:09:39]

I missed this one when looking for users of BookmarkMatch. We don't have any
easy way to get the BookmarkNode from the TitledUrlNode here, so I added an ID
accessor to the interface.

We can safely replace the type() call with Type::URL because BookmarkClient
already prevents us from adding any non-URL nodes to the index.

[sky, 2016/12/08 23:01:07]

Is there a reason this code can't static cast to BookmarkNode? Will this code
ever be used with anything else?

[mattreynolds, 2016/12/09 02:01:14]

It's safe, for some reason I thought such casts were discouraged.

         ToJavaIntArray(env, title_match_start_positions),
         ToJavaIntArray(env, title_match_end_positions),
         ToJavaIntArray(env, url_match_start_positions),