Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(312)

Side by Side Diff: components/bookmarks/browser/bookmark_index.h

Issue 2537223008: Add TitledUrlIndex for indexing arbitrary title/URL pairs (Closed)
Patch Set: const Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « components/bookmarks/browser/BUILD.gn ('k') | components/bookmarks/browser/bookmark_index.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef COMPONENTS_BOOKMARKS_BROWSER_BOOKMARK_INDEX_H_ 5 #ifndef COMPONENTS_BOOKMARKS_BROWSER_BOOKMARK_INDEX_H_
6 #define COMPONENTS_BOOKMARKS_BROWSER_BOOKMARK_INDEX_H_ 6 #define COMPONENTS_BOOKMARKS_BROWSER_BOOKMARK_INDEX_H_
7 7
8 #include <stddef.h> 8 #include <stddef.h>
9 9
10 #include <map> 10 #include <map>
11 #include <set> 11 #include <set>
12 #include <string> 12 #include <string>
13 #include <vector> 13 #include <vector>
14 14
15 #include "base/macros.h" 15 #include "base/macros.h"
16 #include "base/strings/string16.h" 16 #include "base/strings/string16.h"
17 #include "components/query_parser/query_parser.h" 17 #include "components/query_parser/query_parser.h"
18 18
19 namespace bookmarks { 19 namespace bookmarks {
20 20
21 class BookmarkClient; 21 class BookmarkClient;
22 class BookmarkNode; 22 class TitledUrlNode;
23 struct BookmarkMatch; 23 struct BookmarkMatch;
24 24
25 // BookmarkIndex maintains an index of the titles and URLs of bookmarks for 25 // BookmarkIndex maintains an index of the titles and URLs of bookmarks for
26 // quick look up. BookmarkIndex is owned and maintained by BookmarkModel, you 26 // quick look up. BookmarkIndex is owned and maintained by BookmarkModel, you
27 // shouldn't need to interact directly with BookmarkIndex. 27 // shouldn't need to interact directly with BookmarkIndex.
28 // 28 //
29 // BookmarkIndex maintains the index (index_) as a map of sets. The map (type 29 // BookmarkIndex maintains the index (index_) as a map of sets. The map (type
30 // Index) maps from a lower case string to the set (type NodeSet) of 30 // Index) maps from a lower case string to the set (type NodeSet) of
31 // BookmarkNodes that contain that string in their title or URL. 31 // TitledUrlNodes that contain that string in their title or URL.
32 class BookmarkIndex { 32 class BookmarkIndex {
33 public: 33 public:
34 BookmarkIndex(BookmarkClient* client); 34 BookmarkIndex(BookmarkClient* client);
35 ~BookmarkIndex(); 35 ~BookmarkIndex();
36 36
37 // Invoked when a bookmark has been added to the model. 37 // Invoked when a title/URL pair has been added to the model.
38 void Add(const BookmarkNode* node); 38 void Add(const TitledUrlNode* node);
39 39
40 // Invoked when a bookmark has been removed from the model. 40 // Invoked when a title/URL pair has been removed from the model.
41 void Remove(const BookmarkNode* node); 41 void Remove(const TitledUrlNode* node);
42 42
43 // Returns up to |max_count| of bookmarks containing each term from the text 43 // Returns up to |max_count| of matches containing each term from the text
44 // |query| in either the title or the URL. 44 // |query| in either the title or the URL.
45 void GetBookmarksMatching(const base::string16& query, 45 void GetResultsMatching(const base::string16& query,
46 size_t max_count, 46 size_t max_count,
47 query_parser::MatchingAlgorithm matching_algorithm, 47 query_parser::MatchingAlgorithm matching_algorithm,
48 std::vector<BookmarkMatch>* results); 48 std::vector<BookmarkMatch>* results);
49 49
50 private: 50 private:
51 typedef std::vector<const BookmarkNode*> Nodes; 51 using TitledUrlNodes = std::vector<const TitledUrlNode*>;
52 typedef std::set<const BookmarkNode*> NodeSet; 52 using TitledUrlNodeSet = std::set<const TitledUrlNode*>;
53 typedef std::map<base::string16, NodeSet> Index; 53 using Index = std::map<base::string16, TitledUrlNodeSet>;
54 54
55 // Constructs |sorted_nodes| by taking the matches in |matches| and sorting 55 // Constructs |sorted_nodes| by taking the matches in |matches| and sorting
56 // them in decreasing order of typed count (if supported by the client) and 56 // them in decreasing order of typed count (if supported by the client) and
57 // deduping them. 57 // deduping them.
58 void SortMatches(const NodeSet& matches, Nodes* sorted_nodes) const; 58 void SortMatches(const TitledUrlNodeSet& matches,
59 TitledUrlNodes* sorted_nodes) const;
59 60
60 // Add |node| to |results| if the node matches the query. 61 // Add |node| to |results| if the node matches the query.
61 void AddMatchToResults(const BookmarkNode* node, 62 void AddMatchToResults(const TitledUrlNode* node,
62 query_parser::QueryParser* parser, 63 query_parser::QueryParser* parser,
63 const query_parser::QueryNodeVector& query_nodes, 64 const query_parser::QueryNodeVector& query_nodes,
64 std::vector<BookmarkMatch>* results); 65 std::vector<BookmarkMatch>* results);
65 66
66 // Populates |matches| for the specified term. If |first_term| is true, this 67 // Populates |matches| for the specified term. If |first_term| is true, this
67 // is the first term in the query. Returns true if there is at least one node 68 // is the first term in the query. Returns true if there is at least one node
68 // matching the term. 69 // matching the term.
69 bool GetBookmarksMatchingTerm( 70 bool GetResultsMatchingTerm(
70 const base::string16& term, 71 const base::string16& term,
71 bool first_term, 72 bool first_term,
72 query_parser::MatchingAlgorithm matching_algorithm, 73 query_parser::MatchingAlgorithm matching_algorithm,
73 NodeSet* matches); 74 TitledUrlNodeSet* matches);
74 75
75 // Returns the set of query words from |query|. 76 // Returns the set of query words from |query|.
76 std::vector<base::string16> ExtractQueryWords(const base::string16& query); 77 std::vector<base::string16> ExtractQueryWords(const base::string16& query);
77 78
78 // Adds |node| to |index_|. 79 // Adds |node| to |index_|.
79 void RegisterNode(const base::string16& term, const BookmarkNode* node); 80 void RegisterNode(const base::string16& term, const TitledUrlNode* node);
80 81
81 // Removes |node| from |index_|. 82 // Removes |node| from |index_|.
82 void UnregisterNode(const base::string16& term, const BookmarkNode* node); 83 void UnregisterNode(const base::string16& term, const TitledUrlNode* node);
83 84
84 Index index_; 85 Index index_;
85 86
86 BookmarkClient* const client_; 87 BookmarkClient* const client_;
87 88
88 DISALLOW_COPY_AND_ASSIGN(BookmarkIndex); 89 DISALLOW_COPY_AND_ASSIGN(BookmarkIndex);
89 }; 90 };
90 91
91 } // namespace bookmarks 92 } // namespace bookmarks
92 93
93 #endif // COMPONENTS_BOOKMARKS_BROWSER_BOOKMARK_INDEX_H_ 94 #endif // COMPONENTS_BOOKMARKS_BROWSER_BOOKMARK_INDEX_H_
OLDNEW
« no previous file with comments | « components/bookmarks/browser/BUILD.gn ('k') | components/bookmarks/browser/bookmark_index.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698