Chromium Code Reviews
        
  DescriptionRevert of [wrapper-tracing] Fix WebGL extension and attachment handling (patchset #1 id:1 of https://codereview.chromium.org/2539113002/ )
Reason for revert:
We're seeing failures on a some of the MacOSX WebGL Conformance tests since this landed -- not a lot of tests, but enough that it's showing up regularly in the sheriff queue, and I can see it in the GPU bots as well.
This is the only commit in the range that seems to touch both WebGL and memory management, so reverting speculatively. Sorry for that :(
Recent crash log:
https://chromium-swarm.appspot.com/task?id=32cf819f348ef610&refresh=10&show_raw=1
From build https://build.chromium.org/p/chromium.gpu/builders/Mac%2010.10%20Debug%20%28Intel%29/builds/20529
Original issue's description:
> [wrapper-tracing] Fix WebGL extension and attachment handling
>
> Fixes a wrapper tracing issue where ExtensionTracker and WebGLAttachment were
> not handled properly. Has no affect on regular Oilpan garbage collection.
>
> With wrapper tracing enabled this could've resulting in wrappers for typed
> extensions and attachments being prematurely collected.
>
> The issue was flushed out when we were able to generate compile-time errors
> instead of having a catch-all dispatcher at runtime in
> http://crrev.com/2533383003.
>
> BUG=chromium:468240
> CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
>
> Committed: https://crrev.com/fb0beca59e6cc67a6f5b599476c8a3b27ce0418b
> Cr-Commit-Position: refs/heads/master@{#435262}
TBR=haraken@chromium.org,hlopko@chromium.org,mlippautz@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=chromium:468240
Committed: https://crrev.com/642ffe61d39f2b99e50bb4aeb6e2d41cd3fe26ac
Cr-Commit-Position: refs/heads/master@{#435401}
   
  Patch Set 1 #
 Messages
    Total messages: 9 (4 generated)
     
  
  
       | 
    |||||||||||||||||||||||||||||||||||||