Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(273)

Issue 2537223007: Revert of [wrapper-tracing] Fix WebGL extension and attachment handling (Closed)

Created:
4 years ago by iclelland
Modified:
4 years ago
CC:
Marcel Hlopko, blink-reviews, chromium-reviews, Ken Russell (switch to Gerrit)
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of [wrapper-tracing] Fix WebGL extension and attachment handling (patchset #1 id:1 of https://codereview.chromium.org/2539113002/ ) Reason for revert: We're seeing failures on a some of the MacOSX WebGL Conformance tests since this landed -- not a lot of tests, but enough that it's showing up regularly in the sheriff queue, and I can see it in the GPU bots as well. This is the only commit in the range that seems to touch both WebGL and memory management, so reverting speculatively. Sorry for that :( Recent crash log: https://chromium-swarm.appspot.com/task?id=32cf819f348ef610&refresh=10&show_raw=1 From build https://build.chromium.org/p/chromium.gpu/builders/Mac%2010.10%20Debug%20%28Intel%29/builds/20529 Original issue's description: > [wrapper-tracing] Fix WebGL extension and attachment handling > > Fixes a wrapper tracing issue where ExtensionTracker and WebGLAttachment were > not handled properly. Has no affect on regular Oilpan garbage collection. > > With wrapper tracing enabled this could've resulting in wrappers for typed > extensions and attachments being prematurely collected. > > The issue was flushed out when we were able to generate compile-time errors > instead of having a catch-all dispatcher at runtime in > http://crrev.com/2533383003. > > BUG=chromium:468240 > CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel > > Committed: https://crrev.com/fb0beca59e6cc67a6f5b599476c8a3b27ce0418b > Cr-Commit-Position: refs/heads/master@{#435262} TBR=haraken@chromium.org,hlopko@chromium.org,mlippautz@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=chromium:468240 Committed: https://crrev.com/642ffe61d39f2b99e50bb4aeb6e2d41cd3fe26ac Cr-Commit-Position: refs/heads/master@{#435401}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -25 lines) Patch
M third_party/WebKit/Source/modules/webgl/WebGLFramebuffer.h View 1 chunk +1 line, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/webgl/WebGLFramebuffer.cpp View 6 chunks +6 lines, -13 lines 0 comments Download
M third_party/WebKit/Source/modules/webgl/WebGLRenderingContextBase.h View 2 chunks +3 lines, -10 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
iclelland
Created Revert of [wrapper-tracing] Fix WebGL extension and attachment handling
4 years ago (2016-11-30 20:26:19 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2537223007/1
4 years ago (2016-11-30 20:26:43 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-11-30 20:29:47 UTC) #6
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/642ffe61d39f2b99e50bb4aeb6e2d41cd3fe26ac Cr-Commit-Position: refs/heads/master@{#435401}
4 years ago (2016-11-30 20:34:27 UTC) #8
haraken
4 years ago (2016-11-30 23:28:25 UTC) #9
Message was sent while issue was closed.
LGTM

Powered by Google App Engine
This is Rietveld 408576698