Cleanup after removal of the SVGViewSpec interface

third_party/WebKit/Source/core/svg/properties/SVGAnimatedProperty.h

 /*
  * Copyright (C) 2013 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
 G*     * Redistributions in binary form must reproduce the above
@@ skipping 13 matching lines @@
  * LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
  * DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
  * THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
  * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
  * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
  */
 
 #ifndef SVGAnimatedProperty_h
 #define SVGAnimatedProperty_h
 
-#include "bindings/core/v8/ExceptionState.h"
-#include "core/dom/ExceptionCode.h"
 #include "core/svg/SVGParsingError.h"
 #include "core/svg/properties/SVGPropertyInfo.h"
 #include "core/svg/properties/SVGPropertyTearOff.h"
 #include "platform/heap/Handle.h"
 #include "wtf/Noncopyable.h"
 
 namespace blink {
 
+class ExceptionState;
 class SVGElement;
 
 class SVGAnimatedPropertyBase
     : public GarbageCollectedFinalized<SVGAnimatedPropertyBase> {
   WTF_MAKE_NONCOPYABLE(SVGAnimatedPropertyBase);
 
  public:
   virtual ~SVGAnimatedPropertyBase();
 
   virtual SVGPropertyBase* currentValueBase() = 0;
@@ skipping 17 matching lines @@
   const QualifiedName& attributeName() const { return m_attributeName; }
 
   CSSPropertyID cssPropertyId() const {
     return static_cast<CSSPropertyID>(m_cssPropertyId);
   }
 
   bool hasPresentationAttributeMapping() const {
     return cssPropertyId() != CSSPropertyInvalid;
   }
 
-  bool isReadOnly() const { return m_isReadOnly; }
-
-  void setReadOnly() { m_isReadOnly = true; }
-
   bool isSpecified() const;
 
   DEFINE_INLINE_VIRTUAL_TRACE() {}
 
  protected:
   SVGAnimatedPropertyBase(AnimatedPropertyType,
                           SVGElement*,
                           const QualifiedName& attributeName,
                           CSSPropertyID = CSSPropertyInvalid);
 
  private:
   static_assert(NumberOfAnimatedPropertyTypes <= (1u << 5),
                 "enough bits for AnimatedPropertyType (m_type)");
   static constexpr int kCssPropertyBits = 9;
   static_assert((1u << kCssPropertyBits) - 1 >= lastCSSProperty,
                 "enough bits for CSS property ids");
 
   const unsigned m_type : 5;
   const unsigned m_cssPropertyId : kCssPropertyBits;
-  unsigned m_isReadOnly : 1;
 
   // This raw pointer is safe since the SVG element is guaranteed to be kept
   // alive by a V8 wrapper.
   // See http://crbug.com/528275 for the detail.
   UntracedMember<SVGElement> m_contextElement;
 
   const QualifiedName& m_attributeName;
 };
 
 template <typename Property>
@@ skipping 75 matching lines @@
     SVGAnimatedPropertyBase::synchronizeAttribute();
     m_baseValueUpdated = false;
   }
 
   // SVGAnimated* DOM Spec implementations:
 
   // baseVal()/setBaseVal()/animVal() are only to be used from SVG DOM
   // implementation.  Use currentValue() from C++ code.
   PrimitiveType baseVal() { return this->baseValue()->value(); }
 
-  void setBaseVal(PrimitiveType value, ExceptionState& exceptionState) {
-    if (this->isReadOnly()) {
-      exceptionState.throwDOMException(NoModificationAllowedError,
-                                       "The attribute is read-only.");
-      return;
-    }
-
+  void setBaseVal(PrimitiveType value, ExceptionState&) {
     this->baseValue()->setValue(value);
     m_baseValueUpdated = true;
 
     ASSERT(this->attributeName() != QualifiedName::null());
     this->contextElement()->invalidateSVGAttributes();
     this->contextElement()->svgAttributeBaseValChanged(this->attributeName());
   }
 
   PrimitiveType animVal() {
     this->contextElement()->ensureAttributeAnimValUpdated();
@@ skipping 50 matching lines @@
 
   // SVGAnimated* DOM Spec implementations:
 
   // baseVal()/animVal() are only to be used from SVG DOM implementation.
   // Use currentValue() from C++ code.
   virtual TearOffType* baseVal() {
     if (!m_baseValTearOff) {
       m_baseValTearOff =
           TearOffType::create(this->baseValue(), this->contextElement(),
                               PropertyIsNotAnimVal, this->attributeName());
-      if (this->isReadOnly())
-        m_baseValTearOff->setIsReadOnlyProperty();
     }
-
-    return m_baseValTearOff.get();
+    return m_baseValTearOff;
   }
 
   TearOffType* animVal() {
-    if (!m_animValTearOff)
+    if (!m_animValTearOff) {
       m_animValTearOff =
           TearOffType::create(this->currentValue(), this->contextElement(),
                               PropertyIsAnimVal, this->attributeName());
-
-    return m_animValTearOff.get();
+    }
+    return m_animValTearOff;
   }
 
   DEFINE_INLINE_VIRTUAL_TRACE() {
     visitor->trace(m_baseValTearOff);
     visitor->trace(m_animValTearOff);
     SVGAnimatedPropertyCommon<Property>::trace(visitor);
   }
 
  protected:
   SVGAnimatedProperty(SVGElement* contextElement,
@@ skipping 49 matching lines @@
                       CSSPropertyID cssPropertyId = CSSPropertyInvalid)
       : SVGAnimatedPropertyCommon<Property>(contextElement,
                                             attributeName,
                                             initialValue,
                                             cssPropertyId) {}
 };
 
 }  // namespace blink
 
 #endif  // SVGAnimatedProperty_h