third_party/WebKit/LayoutTests/fast/filesystem/cross-filesystem-op.html - Issue 2537193003: Make fast/filesystem/cross-filesystem-op.html insensitive to test order

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/LayoutTests/fast/filesystem/cross-filesystem-op.html

Issue 2537193003: Make fast/filesystem/cross-filesystem-op.html insensitive to test order (Closed)

Patch Set: use template string rather than concatenation Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/RandomOrderExpectations ('k') | third_party/WebKit/LayoutTests/fast/filesystem/not-enough-arguments.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/LayoutTests/fast/filesystem/cross-filesystem-op.html

diff --git a/third_party/WebKit/LayoutTests/fast/filesystem/cross-filesystem-op.html b/third_party/WebKit/LayoutTests/fast/filesystem/cross-filesystem-op.html

index 5c1f8f753406f903f284af8a82b6021a9b80ae85..94a75e5e9f525f7d4d1ea92a36decc50bce3c325 100644

--- a/third_party/WebKit/LayoutTests/fast/filesystem/cross-filesystem-op.html

+++ b/third_party/WebKit/LayoutTests/fast/filesystem/cross-filesystem-op.html

@@ -1,5 +1,6 @@

<html>

<body>

+<script src="resources/fs-test-util.js"></script>

<div>This tests basic cross-filesystem operations.</div>

<div id="destination" style="min-height:100px; border: solid 1px black">Drop files here if you test this manually</div>

@@ -58,14 +59,16 @@ function errorCallback(msg)

function setupDestFileSystem(successCallback) {

webkitRequestFileSystem(window.TEMPORARY, 1024, function (fs) {

- fs.root.getDirectory(

- destDirectoryPath,

- {create:true},

- function (entry) {

- destTestDirectory = entry;

- successCallback();

- },

- errorCallback('dest: createDirectory(' + destDirectoryPath + ')'));

+ removeAllInDirectory(fs.root, function() {

+ fs.root.getDirectory(

+ destDirectoryPath,

+ {create:true},

+ function (entry) {

+ destTestDirectory = entry;

+ successCallback();

+ },

+ errorCallback(`dest: createDirectory(${destDirectoryPath})`));

+ }, errorCallback('dest: removeAllInDirectory'));

}, errorCallback('dest: requestFileSystem for PERSISTENT'));

}