Make fast/filesystem/cross-filesystem-op.html insensitive to test order

Make fast/filesystem/cross-filesystem-op.html insensitive to test order

Test assumed that '/test' could be created as a directory, which
would fail if a previous test left '/test' behind as a file (as some do).
Make the test clear out the root first, as many other tests do.

Also tweak a few other tests to clean up when done, but not all tests
were inspected/updated.

R=jeffcarp@chromium.org
BUG=663852
Committed: https://crrev.com/7727a1c513f1cd6658e05e2fe95ccf293b5cc8d5
Cr-Commit-Position: refs/heads/master@{#435125}

[jsbell, 2016-11-29 19:26:11]

The CQ bit was checked by jsbell@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-29 19:26:26]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[jsbell, 2016-11-29 19:26:47]

Description was changed from

==========
Make fast/filesystem/cross-filesystem-op.html insensitive to test order

Test assumed that '/test' could be created as a directory, which
would fail if a previous test left '/test' behind as a file (as some do).
Make the test clear out the root first, as many other tests do.

R=jeffcarp@chromium.org
BUG=663852
==========

to

==========
Make fast/filesystem/cross-filesystem-op.html insensitive to test order

Test assumed that '/test' could be created as a directory, which
would fail if a previous test left '/test' behind as a file (as some do).
Make the test clear out the root first, as many other tests do.

Also tweak a few other tests to clean up when done, but not all tests
were inspected/updated.

R=jeffcarp@chromium.org
BUG=663852
==========

[jsbell, 2016-11-29 19:26:57]

jeffcarp@ - please take a look?

[commit-bot: I haz the power, 2016-11-29 20:38:05]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-29 20:38:05]

Dry run: This issue passed the CQ dry run.

[jeffcarp, 2016-11-29 21:38:28]

lgtm, thanks for looking into this!

https://codereview.chromium.org/2537193003/diff/20001/third_party/WebKit/Layo...
File third_party/WebKit/LayoutTests/fast/filesystem/cross-filesystem-op.html
(right):

https://codereview.chromium.org/2537193003/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/fast/filesystem/cross-filesystem-op.html:70:
errorCallback('dest: createDirectory(' + destDirectoryPath + ')'));
Just curious, are ES2015 template strings OK for layout tests? Looks like it
would make this line cleaner.

[jsbell, 2016-11-29 21:41:15]

https://codereview.chromium.org/2537193003/diff/20001/third_party/WebKit/Layo...
File third_party/WebKit/LayoutTests/fast/filesystem/cross-filesystem-op.html
(right):

https://codereview.chromium.org/2537193003/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/fast/filesystem/cross-filesystem-op.html:70:
errorCallback('dest: createDirectory(' + destDirectoryPath + ')'));
On 2016/11/29 21:38:28, jeffcarp wrote:
> Just curious, are ES2015 template strings OK for layout tests? Looks like it
> would make this line cleaner.

Sure.

[jsbell, 2016-11-29 21:42:11]

The CQ bit was checked by jsbell@chromium.org

[jsbell, 2016-11-29 21:42:11]

The patchset sent to the CQ was uploaded after l-g-t-m from
jeffcarp@chromium.org
Link to the patchset: https://codereview.chromium.org/2537193003/#ps40001
(title: "use template string rather than concatenation")

[commit-bot: I haz the power, 2016-11-29 21:42:54]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-29 23:46:23]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-29 23:46:24]

Try jobs failed on following builders:
  chromeos_amd64-generic_chromium_compile_only_ng on
master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL)
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, no
build URL)

[jsbell, 2016-11-30 00:05:18]

The CQ bit was checked by jsbell@chromium.org

[commit-bot: I haz the power, 2016-11-30 00:06:05]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-30 02:05:50]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1480464318082020,
"parent_rev": "d4a596a2fc3f2292f7efe9fd6cee431f286e8f7b", "commit_rev":
"cc396c03903688e61af191af58960bb49c95270c"}

[commit-bot: I haz the power, 2016-11-30 02:06:19]

Description was changed from

==========
Make fast/filesystem/cross-filesystem-op.html insensitive to test order

Test assumed that '/test' could be created as a directory, which
would fail if a previous test left '/test' behind as a file (as some do).
Make the test clear out the root first, as many other tests do.

Also tweak a few other tests to clean up when done, but not all tests
were inspected/updated.

R=jeffcarp@chromium.org
BUG=663852
==========

to

==========
Make fast/filesystem/cross-filesystem-op.html insensitive to test order

Test assumed that '/test' could be created as a directory, which
would fail if a previous test left '/test' behind as a file (as some do).
Make the test clear out the root first, as many other tests do.

Also tweak a few other tests to clean up when done, but not all tests
were inspected/updated.

R=jeffcarp@chromium.org
BUG=663852
==========

[commit-bot: I haz the power, 2016-11-30 02:06:20]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-11-30 02:08:04]

Description was changed from

==========
Make fast/filesystem/cross-filesystem-op.html insensitive to test order

Test assumed that '/test' could be created as a directory, which
would fail if a previous test left '/test' behind as a file (as some do).
Make the test clear out the root first, as many other tests do.

Also tweak a few other tests to clean up when done, but not all tests
were inspected/updated.

R=jeffcarp@chromium.org
BUG=663852
==========

to

==========
Make fast/filesystem/cross-filesystem-op.html insensitive to test order

Test assumed that '/test' could be created as a directory, which
would fail if a previous test left '/test' behind as a file (as some do).
Make the test clear out the root first, as many other tests do.

Also tweak a few other tests to clean up when done, but not all tests
were inspected/updated.

R=jeffcarp@chromium.org
BUG=663852

Committed: https://crrev.com/7727a1c513f1cd6658e05e2fe95ccf293b5cc8d5
Cr-Commit-Position: refs/heads/master@{#435125}
==========

[commit-bot: I haz the power, 2016-11-30 02:08:05]

Patchset 3 (id:??) landed as
https://crrev.com/7727a1c513f1cd6658e05e2fe95ccf293b5cc8d5
Cr-Commit-Position: refs/heads/master@{#435125}