Only create network_instrumentation TracedValue if tracing enabled

third_party/WebKit/Source/platform/network/NetworkInstrumentation.cpp

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "platform/network/NetworkInstrumentation.h"
 
 #include "base/trace_event/trace_event.h"
 #include "platform/network/ResourceLoadPriority.h"
 #include "platform/network/ResourceRequest.h"
 #include "platform/tracing/TracedValue.h"
@@ skipping 14 matching lines @@
       return "Success";
     case RequestOutcome::Fail:
       return "Fail";
     default:
       NOTREACHED();
       // We need to return something to avoid compiler warning.
       return "This should never happen";
   }
 }
 
+// Note: network_instrumentation code should do as much work as possible inside
+// the arguments of trace macros so that very little instrumentation overhead is
+// incurred if the trace category is disabled. See https://crbug.com/669666.
+
+std::unique_ptr<TracedValue> scopedResourceTrackerBeginData(

[caseq, 2016/12/01 18:10:24]

All three could be in anonymous namespace -- unless you're going to make the
call-sites inline.

+    const blink::ResourceRequest& request) {
+  std::unique_ptr<TracedValue> data = TracedValue::create();
+  data->setString("url", request.url().getString());
+  return data;
+}
+
+std::unique_ptr<TracedValue> resourcePrioritySetData(
+    blink::ResourceLoadPriority priority) {
+  std::unique_ptr<TracedValue> data = TracedValue::create();
+  data->setInteger("priority", priority);
+  return data;
+}
+
+std::unique_ptr<TracedValue> endResourceLoadData(RequestOutcome outcome) {
+  std::unique_ptr<TracedValue> data = TracedValue::create();
+  data->setString("outcome", RequestOutcomeToString(outcome));
+  return data;
+}
+
 ScopedResourceLoadTracker::ScopedResourceLoadTracker(
     unsigned long resourceID,
     const blink::ResourceRequest& request)
     : m_resourceLoadContinuesBeyondScope(false), m_resourceID(resourceID) {
-  std::unique_ptr<TracedValue> beginData = TracedValue::create();
-  beginData->setString("url", request.url().getString());
   TRACE_EVENT_NESTABLE_ASYNC_BEGIN1(
       kNetInstrumentationCategory, kResourceLoadTitle,
       TRACE_ID_WITH_SCOPE(kBlinkResourceID, TRACE_ID_LOCAL(resourceID)),
-      "beginData", std::move(beginData));
+      "beginData", scopedResourceTrackerBeginData(request));
 }
 
 ScopedResourceLoadTracker::~ScopedResourceLoadTracker() {
   if (!m_resourceLoadContinuesBeyondScope)
     endResourceLoad(m_resourceID, RequestOutcome::Fail);
 }
 
 void ScopedResourceLoadTracker::resourceLoadContinuesBeyondScope() {
   m_resourceLoadContinuesBeyondScope = true;
 }
 
 void resourcePrioritySet(unsigned long resourceID,
                          blink::ResourceLoadPriority priority) {
-  std::unique_ptr<TracedValue> data = TracedValue::create();
-  data->setInteger("priority", priority);
   TRACE_EVENT_NESTABLE_ASYNC_INSTANT1(
       kNetInstrumentationCategory, kResourcePrioritySetTitle,
       TRACE_ID_WITH_SCOPE(kBlinkResourceID, TRACE_ID_LOCAL(resourceID)), "data",
-      std::move(data));
+      resourcePrioritySetData(priority));
 }
 
 void endResourceLoad(unsigned long resourceID, RequestOutcome outcome) {
-  std::unique_ptr<TracedValue> endData = TracedValue::create();
-  endData->setString("outcome", RequestOutcomeToString(outcome));
   TRACE_EVENT_NESTABLE_ASYNC_END1(
       kNetInstrumentationCategory, kResourceLoadTitle,
       TRACE_ID_WITH_SCOPE(kBlinkResourceID, TRACE_ID_LOCAL(resourceID)),
-      "endData", std::move(endData));
+      "endData", endResourceLoadData(outcome));
 }
 
 }  // namespace network_instrumentation