third_party/WebKit/Source/core/svg/SVGUseElement.cpp - Issue 2537143004: Stop a SVG <use> element from modifying its UA shadow tree when it is removed

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/svg/SVGUseElement.cpp

Issue 2537143004: Stop a SVG <use> element from modifying its UA shadow tree when it is removed (Closed)

Patch Set: Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/svg/SVGUseElement.cpp

diff --git a/third_party/WebKit/Source/core/svg/SVGUseElement.cpp b/third_party/WebKit/Source/core/svg/SVGUseElement.cpp

index 0091e379c49c51509fc433fdddcdec468b55db6e..091fade514573943bcd9de381310def48a40a0d1 100644

--- a/third_party/WebKit/Source/core/svg/SVGUseElement.cpp

+++ b/third_party/WebKit/Source/core/svg/SVGUseElement.cpp

@@ -128,7 +128,8 @@ Node::InsertionNotificationRequest SVGUseElement::insertedInto(

void SVGUseElement::removedFrom(ContainerNode* rootParent) {

SVGGraphicsElement::removedFrom(rootParent);

if (rootParent->isConnected()) {

- clearShadowTree();

+ clearInstanceRoot();

+ removeAllOutgoingReferences();

cancelShadowTreeRecreation();

}

« no previous file with comments | « no previous file | no next file » | no next file with comments »