Update brotli to v1.0.0-snapshot.

ios/chrome/browser/ui/webui/about_ui.cc

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ios/chrome/browser/ui/webui/about_ui.h"
 
 #include <algorithm>
+#include <brotli/decode.h>

[marq (ping after 24h), 2016/11/30 09:17:41]

I have the same concerns about changing the include type as msw@. 

[eustas, 2016/12/02 11:49:41]

Done.

 #include <string>
 #include <utility>
 #include <vector>
 
 #include "base/format_macros.h"
 #include "base/i18n/number_formatting.h"
 #include "base/macros.h"
 #include "base/metrics/statistics_recorder.h"
 #include "base/strings/string_number_conversions.h"
 #include "components/grit/components_resources.h"
 #include "google_apis/gaia/google_service_auth_error.h"
 #include "ios/chrome/browser/browser_state/chrome_browser_state.h"
 #include "ios/chrome/browser/chrome_url_constants.h"
 #include "ios/web/public/url_data_source_ios.h"
 #include "net/base/escape.h"
-#include "third_party/brotli/dec/decode.h"
 #include "ui/base/device_form_factor.h"
 #include "ui/base/resource/resource_bundle.h"
 #include "url/gurl.h"
 
 namespace {
 
 const char kCreditsJsPath[] = "credits.js";
 const char kStringsJsPath[] = "strings.js";
 
 class AboutUIHTMLSource : public web::URLDataSourceIOS {
@@ skipping 90 matching lines @@
   // Add your data source here, in alphabetical order.
   if (source_name_ == kChromeUIChromeURLsHost) {
     response = ChromeURLs();
   } else if (source_name_ == kChromeUICreditsHost) {
     int idr = IDR_ABOUT_UI_CREDITS_HTML;
     if (path == kCreditsJsPath)
       idr = IDR_ABOUT_UI_CREDITS_JS;
     base::StringPiece raw_response =
         ResourceBundle::GetSharedInstance().GetRawDataResource(idr);
     if (idr == IDR_ABOUT_UI_CREDITS_HTML) {
-      size_t decoded_size;
-      const uint8_t* encoded_response_buffer =
-          reinterpret_cast<const uint8_t*>(raw_response.data());
-      CHECK(BrotliDecompressedSize(raw_response.size(), encoded_response_buffer,
-                                   &decoded_size));
-      // Resizing the response and using it as the buffer Brotli decompresses
-      // into.
-      response.resize(decoded_size);
-      CHECK(BrotliDecompressBuffer(raw_response.size(), encoded_response_buffer,
-                                   &decoded_size,
-                                   reinterpret_cast<uint8_t*>(&response[0])) ==
-            BROTLI_RESULT_SUCCESS);
+      const uint8_t* in = reinterpret_cast<const uint8_t*>(raw_response.data());

[marq (ping after 24h), 2016/11/30 09:17:41]

|in| isn't a suitable variable name, since it doesn't describe what the variable
represents. Please keep the old name, |encoded_response_buffer|, unless the
semantics of the API have significantly changed.

Please review the style guide for naming rules
(https://google.github.io/styleguide/cppguide.html#General_Naming_Rules); the
overriding principle is that names must be descriptive.

[eustas, 2016/12/02 11:49:41]

Semantics has changed - now decompression is streaming, so this pointer changes
in a loop, until it reaches the en of input.

Done.

+      size_t available_in = raw_response.size();

[marq (ping after 24h), 2016/11/30 09:17:41]

Likewise, |available_in| isn't a good name here. |raw_size| looks like it might
be better, or maybe |input_bytes_remaining|?

[eustas, 2016/12/02 11:49:41]

Done.

+      BrotliDecoderState* decoder = BrotliDecoderCreateInstance(0, 0, 0);

[marq (ping after 24h), 2016/11/30 09:17:41]

I find 'BrotliDecoderState' a very counterintuitive type name. For how it is
used, this seems to be a pointer to a decoder instance, but the type name sounds
like it's a scalar value of some kind that indicates the state of a decoder
instance.

[marq (ping after 24h), 2016/11/30 09:17:41]

Please insert inline comments to document the 0 parameters. The maintainers of
this code are very likely to know nothing about Brotli.

Do not use 0 for null pointers; use nullptr. See the C++ style guide:
https://google.github.io/styleguide/cppguide.html#0_and_nullptr/NULL

So this should look something like:

BrotliDecoderCreateInstance(nullptr /* no custom allocator */, 
                            nullptr /* no custom deallocator */,
                            nullptr /* no custom memory handle */);

[eustas, 2016/12/02 11:49:41]

Good point. I'll consider renaming this structure in next brotli version.

+      CHECK(!!decoder);
+      while (!BrotliDecoderIsFinished(decoder)) {
+        size_t available_out = 0;

[marq (ping after 24h), 2016/11/30 09:17:41]

Is |available_out| really something like |output_bytes_remaining|?

[eustas, 2016/12/02 11:49:41]

Yup. Fixed.

+        CHECK(BrotliDecoderDecompressStream(decoder, &available_in, &in,
+                                            &available_out, 0,

[marq (ping after 24h), 2016/11/30 09:17:41]

Don't use 0 for null pointers here, either.

[eustas, 2016/12/02 11:49:41]

Done.

+                                            0) != BROTLI_DECODER_RESULT_ERROR);
+        const uint8_t* out = BrotliDecoderTakeOutput(decoder, &available_out);
+        response.insert(response.end(), out, out + available_out);
+      }
+      BrotliDecoderDestroyInstance(decoder);
     } else {
       response = raw_response.as_string();
     }
   } else if (source_name_ == kChromeUIHistogramHost) {
     // Note: On other platforms, this is implemented in //content. If there is
     // ever a need for embedders other than //ios/chrome to use
     // chrome://histograms, this code could likely be moved to //io/web.
     base::StatisticsRecorder::WriteHTMLGraph("", &response);
   }
 
@@ skipping 18 matching lines @@
   return web::URLDataSourceIOS::ShouldDenyXFrameOptions();
 }
 
 AboutUI::AboutUI(web::WebUIIOS* web_ui, const std::string& name)
     : web::WebUIIOSController(web_ui) {
   web::URLDataSourceIOS::Add(ios::ChromeBrowserState::FromWebUIIOS(web_ui),
                              new AboutUIHTMLSource(name));
 }
 
 AboutUI::~AboutUI() {}