Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(661)

Issue 2537093002: Check some more invariants on SFIs. (Closed)

Created:
4 years ago by neis
Modified:
4 years ago
Reviewers:
adamk
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Check some more invariants on SFIs. This adds consistency checks for function kind and scope type to SharedFunctionInfoVerify. It also fixes an inconsistency in the creation of a ScopeInfo. R=adamk@chromium.org BUG= Committed: https://crrev.com/ee8e1464d79bead2b325b108d2da0e57b79838e2 Cr-Commit-Position: refs/heads/master@{#41375}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -10 lines) Patch
M src/ast/scopeinfo.cc View 1 chunk +4 lines, -2 lines 0 comments Download
M src/objects-debug.cc View 1 chunk +16 lines, -8 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
neis
4 years ago (2016-11-29 11:27:39 UTC) #1
adamk
lgtm
4 years ago (2016-11-29 19:01:10 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2537093002/1
4 years ago (2016-11-30 07:35:00 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-11-30 08:04:25 UTC) #6
commit-bot: I haz the power
4 years ago (2016-11-30 08:05:06 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ee8e1464d79bead2b325b108d2da0e57b79838e2
Cr-Commit-Position: refs/heads/master@{#41375}

Powered by Google App Engine
This is Rietveld 408576698