Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(371)

Unified Diff: chrome/browser/permissions/permission_context_base.cc

Issue 2537083002: Make dismiss works for PermissionPromptAndroid (Closed)
Patch Set: Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/permissions/permission_context_base.cc
diff --git a/chrome/browser/permissions/permission_context_base.cc b/chrome/browser/permissions/permission_context_base.cc
index 5c99fbd3668796176b5a1b073fa2f16d013f9c3b..dfb08def63ead98be4cdb3d682c6e8821d2e51ad 100644
--- a/chrome/browser/permissions/permission_context_base.cc
+++ b/chrome/browser/permissions/permission_context_base.cc
@@ -224,7 +224,6 @@ void PermissionContextBase::PermissionDecided(
const BrowserPermissionCallback& callback,
bool persist,
ContentSetting content_setting) {
-#if !defined(OS_ANDROID)
raymes 2016/11/30 02:21:48 Hmm - I think currently the permission queue contr
lshang 2016/11/30 04:59:00 Done.
// Infobar persistence and its related UMA is tracked on the infobar
// controller directly.
PermissionRequestGestureType gesture_type =
@@ -243,7 +242,6 @@ void PermissionContextBase::PermissionDecided(
PermissionUmaUtil::PermissionDismissed(permission_type_, gesture_type,
requesting_origin, profile_);
}
-#endif
// Check if we should convert a dismiss decision into a block decision. This
// is gated on enabling the kBlockPromptsIfDismissedOften feature.

Powered by Google App Engine
This is Rietveld 408576698