content/public/android/java/src/org/chromium/content/browser/input/ImeAdapter.java - Issue 2537073002: Fix leaks in InputConnectionHandlerThread

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/public/android/java/src/org/chromium/content/browser/input/ImeAdapter.java

Issue 2537073002: Fix leaks in InputConnectionHandlerThread (Closed)

Patch Set: fix tests Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/public/android/java/src/org/chromium/content/browser/input/ChromiumBaseInputConnection.java ('k') | content/public/android/java/src/org/chromium/content/browser/input/ReplicaInputConnection.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/public/android/java/src/org/chromium/content/browser/input/ImeAdapter.java

diff --git a/content/public/android/java/src/org/chromium/content/browser/input/ImeAdapter.java b/content/public/android/java/src/org/chromium/content/browser/input/ImeAdapter.java

index c240c7bcab2b8c141ced02d288d349f9cf9ac8cb..5c56ab6e6b25cfff1f1e3a33982e545d123d90e2 100644

--- a/content/public/android/java/src/org/chromium/content/browser/input/ImeAdapter.java

+++ b/content/public/android/java/src/org/chromium/content/browser/input/ImeAdapter.java

@@ -508,6 +508,17 @@ public class ImeAdapter {

}

/**

+ * Call this when ImeAdapter gets destroyed.

+ */

+ public void destroy() {

+ if (DEBUG_LOGS) Log.w(TAG, "destroy");

+ resetAndHideKeyboard();

+ if (mInputConnectionFactory != null) {

+ mInputConnectionFactory.destroy();

+ }

+ /**

* Update selection to input method manager.

* @param selectionStart The selection start.