content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java - Issue 2537073002: Fix leaks in InputConnectionHandlerThread

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java

Issue 2537073002: Fix leaks in InputConnectionHandlerThread (Closed)

Patch Set: Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | content/public/android/java/src/org/chromium/content/browser/input/ChromiumBaseInputConnection.java » ('j') | content/public/android/java/src/org/chromium/content/browser/input/ThreadedInputConnectionFactory.java » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java

diff --git a/content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java b/content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java

index d28f3cafecefef49f46f739920630bbae465807b..512ca168947a794ec0f255763931825d24a1d49e 100644

--- a/content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java

+++ b/content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java

@@ -837,7 +837,7 @@ public class ContentViewCore implements AccessibilityStateChangeListener, Displa

mWebContentsObserver = null;

setSmartClipDataListener(null);

setZoomControlsDelegate(null);

- mImeAdapter.resetAndHideKeyboard();

+ mImeAdapter.destroy();

// TODO(igsolla): address TODO in ContentViewClient because ContentViewClient is not

// currently a real Null Object.