Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(17)

Side by Side Diff: content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java

Issue 2537073002: Fix leaks in InputConnectionHandlerThread (Closed)
Patch Set: fix tests Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | content/public/android/java/src/org/chromium/content/browser/input/ChromiumBaseInputConnection.java » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 The Chromium Authors. All rights reserved. 1 // Copyright 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 package org.chromium.content.browser; 5 package org.chromium.content.browser;
6 6
7 import android.annotation.SuppressLint; 7 import android.annotation.SuppressLint;
8 import android.annotation.TargetApi; 8 import android.annotation.TargetApi;
9 import android.app.assist.AssistStructure.ViewNode; 9 import android.app.assist.AssistStructure.ViewNode;
10 import android.content.ClipData; 10 import android.content.ClipData;
(...skipping 819 matching lines...) Expand 10 before | Expand all | Expand 10 after
830 */ 830 */
831 public void destroy() { 831 public void destroy() {
832 removeDisplayAndroidObserver(); 832 removeDisplayAndroidObserver();
833 if (mNativeContentViewCore != 0) { 833 if (mNativeContentViewCore != 0) {
834 nativeOnJavaContentViewCoreDestroyed(mNativeContentViewCore); 834 nativeOnJavaContentViewCoreDestroyed(mNativeContentViewCore);
835 } 835 }
836 mWebContentsObserver.destroy(); 836 mWebContentsObserver.destroy();
837 mWebContentsObserver = null; 837 mWebContentsObserver = null;
838 setSmartClipDataListener(null); 838 setSmartClipDataListener(null);
839 setZoomControlsDelegate(null); 839 setZoomControlsDelegate(null);
840 mImeAdapter.resetAndHideKeyboard(); 840 mImeAdapter.destroy();
841 // TODO(igsolla): address TODO in ContentViewClient because ContentViewC lient is not 841 // TODO(igsolla): address TODO in ContentViewClient because ContentViewC lient is not
842 // currently a real Null Object. 842 // currently a real Null Object.
843 // 843 //
844 // Instead of deleting the client we use the Null Object pattern to avoi d null checks 844 // Instead of deleting the client we use the Null Object pattern to avoi d null checks
845 // in this class. 845 // in this class.
846 mContentViewClient = new ContentViewClient(); 846 mContentViewClient = new ContentViewClient();
847 mWebContents = null; 847 mWebContents = null;
848 mOverscrollRefreshHandler = null; 848 mOverscrollRefreshHandler = null;
849 mNativeContentViewCore = 0; 849 mNativeContentViewCore = 0;
850 mJavaScriptInterfaces.clear(); 850 mJavaScriptInterfaces.clear();
(...skipping 2185 matching lines...) Expand 10 before | Expand all | Expand 10 after
3036 String textTrackTextShadow, String textTrackTextSize); 3036 String textTrackTextShadow, String textTrackTextSize);
3037 3037
3038 private native void nativeExtractSmartClipData(long nativeContentViewCoreImp l, 3038 private native void nativeExtractSmartClipData(long nativeContentViewCoreImp l,
3039 int x, int y, int w, int h); 3039 int x, int y, int w, int h);
3040 3040
3041 private native void nativeSetBackgroundOpaque(long nativeContentViewCoreImpl , boolean opaque); 3041 private native void nativeSetBackgroundOpaque(long nativeContentViewCoreImpl , boolean opaque);
3042 private native boolean nativeIsTouchDragDropEnabled(long nativeContentViewCo reImpl); 3042 private native boolean nativeIsTouchDragDropEnabled(long nativeContentViewCo reImpl);
3043 private native void nativeOnDragEvent(long nativeContentViewCoreImpl, int ac tion, int x, int y, 3043 private native void nativeOnDragEvent(long nativeContentViewCoreImpl, int ac tion, int x, int y,
3044 int screenX, int screenY, String[] mimeTypes, String content); 3044 int screenX, int screenY, String[] mimeTypes, String content);
3045 } 3045 }
OLDNEW
« no previous file with comments | « no previous file | content/public/android/java/src/org/chromium/content/browser/input/ChromiumBaseInputConnection.java » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698