Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(283)

Unified Diff: dashboard/dashboard/elements/group-report-page.html

Issue 2537053003: Changing group reports to use an id for multiple keys. (Closed)
Patch Set: added test Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « dashboard/dashboard/elements/alerts-table.html ('k') | dashboard/dashboard/group_report.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: dashboard/dashboard/elements/group-report-page.html
diff --git a/dashboard/dashboard/elements/group-report-page.html b/dashboard/dashboard/elements/group-report-page.html
index a3acda0fea4d6d601740ddcfbbb8b69a09b0c62c..b40ff87f1ce2565b05a24d61578777821b1112b0 100644
--- a/dashboard/dashboard/elements/group-report-page.html
+++ b/dashboard/dashboard/elements/group-report-page.html
@@ -117,7 +117,8 @@ found in the LICENSE file.
xsrf-token="{{xsrfToken}}"
alert-list="{{alertList}}"
extra-columns="{{extraColumns}}"
- on-changeselection="onAlertSelectionChange"></alerts-table>
+ on-changeselection="onAlertSelectionChange"
+ selected-keys="{{selectedKeys}}"></alerts-table>
</div>
<div id="bottom">
@@ -191,6 +192,11 @@ found in the LICENSE file.
value: false
},
+ selectedKeys: {
+ type: Array,
+ value: () => []
+ },
+
testSuites: {
type: Object,
value: () => { return {}; }
@@ -409,9 +415,17 @@ found in the LICENSE file.
}
},
+ /**
+ * The url params determine what data to request from
+ * /group_report. sid is a hash of a group of keys.
+ */
ready: function() {
this.graphElements_ = {};
var params = {};
+ var sid = uri.getParameter('sid');
+ if (sid) {
+ params['sid'] = sid;
+ }
var keys = uri.getParameter('keys');
if (keys) {
params['keys'] = keys;
@@ -435,6 +449,7 @@ found in the LICENSE file.
this.warningBug = response['warning_bug'];
this.warningMessage = response['warning_message'];
this.alertList = response['alert_list'];
+ this.selectedKeys = response['selected_keys'];
if (this.warningMessage) {
this.fire('display-toast', {
'content': this.$.warningtoast,
« no previous file with comments | « dashboard/dashboard/elements/alerts-table.html ('k') | dashboard/dashboard/group_report.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698