Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(162)

Issue 2537053002: cc : Remove invalid DCHECK from draw_property_utils.cc (Closed)

Created:
4 years ago by jaydasika
Modified:
4 years ago
Reviewers:
ajuma, weiliangc
CC:
cc-bugs_chromium.org, chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

cc : Remove invalid DCHECK from draw_property_utils.cc The DCHECK is invalid because we can have a render surface between the target of scroll parent and scroll child. BUG=663499 CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel Committed: https://crrev.com/4de4c083e4e6500ef998c9a040388c1f58013b6e Cr-Commit-Position: refs/heads/master@{#435008}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+53 lines, -4 lines) Patch
M cc/trees/draw_property_utils.cc View 1 chunk +9 lines, -4 lines 0 comments Download
M cc/trees/layer_tree_host_common_unittest.cc View 1 chunk +44 lines, -0 lines 0 comments Download

Messages

Total messages: 16 (11 generated)
jaydasika
PTAL
4 years ago (2016-11-29 07:21:44 UTC) #5
weiliangc
LGTM
4 years ago (2016-11-29 16:13:40 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2537053002/1
4 years ago (2016-11-29 16:15:17 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-11-29 16:19:46 UTC) #14
commit-bot: I haz the power
4 years ago (2016-11-29 16:23:27 UTC) #16
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/4de4c083e4e6500ef998c9a040388c1f58013b6e
Cr-Commit-Position: refs/heads/master@{#435008}

Powered by Google App Engine
This is Rietveld 408576698