Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Issue 2537023002: [DevTools] Remove workspace-test.js part3. (Closed)

Created:
4 years ago by dgozman
Modified:
4 years ago
Reviewers:
lushnikov
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, kozyatinskiy+blink_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[DevTools] Remove workspace-test.js part3. Extracted the meaningful part of the test which checks multiple scripts in the same html file. BUG=none Committed: https://crrev.com/53a197404ace5cdf68dc51806dcc437881ec8455 Cr-Commit-Position: refs/heads/master@{#434913}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+68 lines, -261 lines) Patch
M third_party/WebKit/LayoutTests/inspector/sources/debugger/resource-script-mapping.html View 1 chunk +38 lines, -204 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector/sources/debugger/resource-script-mapping-expected.txt View 1 chunk +9 lines, -57 lines 0 comments Download
A third_party/WebKit/LayoutTests/inspector/sources/debugger/resources/multiple-scripts.html View 1 chunk +21 lines, -0 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 9 (4 generated)
dgozman
Take a look please.
4 years ago (2016-11-29 02:09:49 UTC) #2
lushnikov
lgtm
4 years ago (2016-11-29 02:19:49 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2537023002/1
4 years ago (2016-11-29 05:22:34 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-11-29 06:34:34 UTC) #7
commit-bot: I haz the power
4 years ago (2016-11-29 06:39:55 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/53a197404ace5cdf68dc51806dcc437881ec8455
Cr-Commit-Position: refs/heads/master@{#434913}

Powered by Google App Engine
This is Rietveld 408576698