Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1251)

Issue 2537003002: Fix Canvas2DLayerBridge IOSurface leak. (Closed)

Created:
4 years ago by erikchen
Modified:
4 years ago
CC:
chromium-reviews, krit, drott+blinkwatch_chromium.org, ajuma+watch-canvas_chromium.org, dshwang, pdr+graphicswatchlist_chromium.org, jbroman, blink-reviews-platform-graphics_chromium.org, Rik, f(malita), blink-reviews, danakj+watch_chromium.org, ajuma+watch_chromium.org, Stephen Chennney, rwlbuis
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix Canvas2DLayerBridge IOSurface leak. The IOSurface wasn't being released when the Canvas2DLayerBridge was destroyed before the texture was returned. BUG=662696 Committed: https://crrev.com/5b30ac6ab9aec356b4a4057b5f934feac9821a7f Cr-Commit-Position: refs/heads/master@{#435050}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+65 lines, -6 lines) Patch
M third_party/WebKit/Source/platform/graphics/Canvas2DLayerBridge.cpp View 2 chunks +10 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/Canvas2DLayerBridgeTest.cpp View 4 chunks +55 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (8 generated)
erikchen
ccameron, junov: Please review. I've confirmed that the test fails before my fix, and passes ...
4 years ago (2016-11-29 01:50:01 UTC) #3
Justin Novosad
lgtm
4 years ago (2016-11-29 16:22:16 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2537003002/1
4 years ago (2016-11-29 19:02:06 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-11-29 19:13:36 UTC) #11
commit-bot: I haz the power
4 years ago (2016-11-29 19:20:11 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/5b30ac6ab9aec356b4a4057b5f934feac9821a7f
Cr-Commit-Position: refs/heads/master@{#435050}

Powered by Google App Engine
This is Rietveld 408576698