Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10)

Issue 2536993003: [ast] Mark removed scopes as such. (Closed)

Created:
4 years ago by neis
Modified:
4 years ago
Reviewers:
adamk
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[ast] Mark removed scopes as such. When removing a scope (see FinalizeBlockScope), remember the removal by making the scope its own sibling. This avoid recalculating the information later on. R=adamk@chromium.org BUG= Committed: https://crrev.com/881bacffe3bcbba59169a8dc671b9c2c67dc1fb7 Cr-Commit-Position: refs/heads/master@{#41374}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -17 lines) Patch
M src/ast/scopes.cc View 3 chunks +12 lines, -17 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
neis
4 years ago (2016-11-29 10:09:37 UTC) #1
adamk
lgtm
4 years ago (2016-11-29 19:00:03 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2536993003/1
4 years ago (2016-11-30 07:34:48 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-11-30 07:59:31 UTC) #6
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/881bacffe3bcbba59169a8dc671b9c2c67dc1fb7 Cr-Commit-Position: refs/heads/master@{#41374}
4 years ago (2016-11-30 08:00:05 UTC) #8
Michael Achenbach
4 years ago (2016-12-01 08:11:43 UTC) #9
Message was sent while issue was closed.
https://build.chromium.org/p/client.v8.ports/builders/V8%20Arm/builds/1648
flakes since this CL.

This runs on chromebooks. Can there be a connection?

Powered by Google App Engine
This is Rietveld 408576698