Disable redraw lock when using DirectComposition.

Disable redraw lock when using DirectComposition.

This can cause windows to flicker black when they're made invisible. It
should also be unnecessary, as WS_CLIPCHILDREN should prevent
DefWindowProc from modifying window contents in the area where Chrome is
rendering.

BUG=667731
Committed: https://crrev.com/b31f7c090c114097fc46ca120a3d0d221a238e88
Cr-Commit-Position: refs/heads/master@{#435203}

[jbauman, 2016-11-29 01:32:03]

The CQ bit was checked by jbauman@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-29 01:34:13]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[jbauman, 2016-11-29 02:30:04]

jbauman@chromium.org changed reviewers:
+ sky@chromium.org

[commit-bot: I haz the power, 2016-11-29 02:49:46]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-29 02:49:47]

Dry run: This issue passed the CQ dry run.

[sky, 2016-11-29 18:05:19]

https://codereview.chromium.org/2536983002/diff/1/ui/views/win/hwnd_message_h...
File ui/views/win/hwnd_message_handler.cc (right):

https://codereview.chromium.org/2536983002/diff/1/ui/views/win/hwnd_message_h...
ui/views/win/hwnd_message_handler.cc:289: if (was_visible_ && should_lock_ &&
::IsWindow(hwnd_))
Can should_lock_ include was_visible_ and ::IsWindow(hwnd_) so that this
conditional becomes:

if (should_lock_)
  ..

This would mean getting rid of the member was_visible_.

[jbauman, 2016-11-29 22:28:43]

The CQ bit was checked by jbauman@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-29 22:29:24]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[jbauman, 2016-11-29 22:47:49]

The CQ bit was checked by jbauman@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-29 22:47:59]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[jbauman, 2016-11-29 23:43:02]

PTAL.

On 2016/11/29 18:05:19, sky wrote:
>
https://codereview.chromium.org/2536983002/diff/1/ui/views/win/hwnd_message_h...
> File ui/views/win/hwnd_message_handler.cc (right):
> 
>
https://codereview.chromium.org/2536983002/diff/1/ui/views/win/hwnd_message_h...
> ui/views/win/hwnd_message_handler.cc:289: if (was_visible_ && should_lock_ &&
> ::IsWindow(hwnd_))
> Can should_lock_ include was_visible_ and ::IsWindow(hwnd_) so that this
> conditional becomes:
> 
> if (should_lock_)
>   ..
> 
> This would mean getting rid of the member was_visible_.

Done (I kept ::IsWindow(hwnd_) in the destructor for the case where hwnd_ is
destroyed while the lock is held).

[sky, 2016-11-30 00:01:50]

LGTM

https://codereview.chromium.org/2536983002/diff/40001/ui/views/win/hwnd_messa...
File ui/views/win/hwnd_message_handler.cc (right):

https://codereview.chromium.org/2536983002/diff/40001/ui/views/win/hwnd_messa...
ui/views/win/hwnd_message_handler.cc:309: bool should_lock_;
Make const

[jbauman, 2016-11-30 00:27:00]

The CQ bit was checked by jbauman@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-30 00:27:40]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-30 02:29:37]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-30 02:29:38]

Dry run: Try jobs failed on following builders:
  blimp_linux_dbg on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build
URL)
  cast_shell_linux on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build
URL)
  chromeos_amd64-generic_chromium_compile_only_ng on
master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL)
  chromeos_daisy_chromium_compile_only_ng on master.tryserver.chromium.linux
(JOB_TIMED_OUT, no build URL)
  chromeos_x86-generic_chromium_compile_only_ng on
master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL)
  linux_chromium_chromeos_compile_dbg_ng on master.tryserver.chromium.linux
(JOB_TIMED_OUT, no build URL)
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_TIMED_OUT, no build URL)
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux
(JOB_TIMED_OUT, no build URL)
  linux_chromium_clobber_rel_ng on master.tryserver.chromium.linux
(JOB_TIMED_OUT, no build URL)
  linux_chromium_compile_dbg_ng on master.tryserver.chromium.linux
(JOB_TIMED_OUT, no build URL)

[jbauman, 2016-11-30 02:35:03]

The CQ bit was checked by jbauman@chromium.org

[jbauman, 2016-11-30 02:35:03]

The patchset sent to the CQ was uploaded after l-g-t-m from sky@chromium.org
Link to the patchset: https://codereview.chromium.org/2536983002/#ps60001
(title: "make const")

[commit-bot: I haz the power, 2016-11-30 02:36:00]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-30 04:37:12]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-30 04:37:13]

Try jobs failed on following builders:
  blimp_linux_dbg on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build
URL)
  cast_shell_linux on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build
URL)
  chromeos_amd64-generic_chromium_compile_only_ng on
master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL)
  chromeos_x86-generic_chromium_compile_only_ng on
master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL)
  chromium_presubmit on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build
URL)
  linux_chromium_chromeos_compile_dbg_ng on master.tryserver.chromium.linux
(JOB_TIMED_OUT, no build URL)
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_TIMED_OUT, no build URL)
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux
(JOB_TIMED_OUT, no build URL)
  linux_chromium_clobber_rel_ng on master.tryserver.chromium.linux
(JOB_TIMED_OUT, no build URL)
  linux_chromium_compile_dbg_ng on master.tryserver.chromium.linux
(JOB_TIMED_OUT, no build URL)

[jbauman, 2016-11-30 09:52:54]

The CQ bit was checked by jbauman@chromium.org

[commit-bot: I haz the power, 2016-11-30 09:53:21]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-30 09:58:33]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1480499574267400,
"parent_rev": "a16d0b6f397e1bd15afa9e08bfd1a9a2a51835a3", "commit_rev":
"dc5c6649e14fc487a2e29d549a267ab20a288370"}

[commit-bot: I haz the power, 2016-11-30 09:59:01]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-11-30 10:01:26]

Description was changed from

==========
Disable redraw lock when using DirectComposition.

This can cause windows to flicker black when they're made invisible. It
should also be unnecessary, as WS_CLIPCHILDREN should prevent
DefWindowProc from modifying window contents in the area where Chrome is
rendering.

BUG=667731
==========

to

==========
Disable redraw lock when using DirectComposition.

This can cause windows to flicker black when they're made invisible. It
should also be unnecessary, as WS_CLIPCHILDREN should prevent
DefWindowProc from modifying window contents in the area where Chrome is
rendering.

BUG=667731

Committed: https://crrev.com/b31f7c090c114097fc46ca120a3d0d221a238e88
Cr-Commit-Position: refs/heads/master@{#435203}
==========

[commit-bot: I haz the power, 2016-11-30 10:01:27]

Patchset 4 (id:??) landed as
https://crrev.com/b31f7c090c114097fc46ca120a3d0d221a238e88
Cr-Commit-Position: refs/heads/master@{#435203}