Add pdfium::MakeRetain<>() helper function.

Add pdfium::MakeRetain<>() helper function.

Part of the work to get rid of |new|s.  Stripped from a forthcoming CL.

Committed: https://pdfium.googlesource.com/pdfium/+/b90c71a7b8530c5bd15740d0bb680f097920cd65

[Tom Sepez, 2016-11-29 21:22:49]

Description was changed from

==========
Add pdfium::MakeRetain<>() helper function.
==========

to

==========
Add pdfium::MakeRetain<>() helper function.

Part of the work to get rid of |new|s.  Stripped from a forthcoming CL.
==========

[Tom Sepez, 2016-11-29 21:22:50]

tsepez@chromium.org changed reviewers:
+ npm@chromium.org, weili@chromium.org

[Tom Sepez, 2016-11-29 21:22:55]

The CQ bit was checked by tsepez@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-29 21:23:05]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Tom Sepez, 2016-11-29 21:24:46]

Wei, NPM, ready for review.

[npm, 2016-11-29 22:25:30]

https://codereview.chromium.org/2536973003/diff/40001/core/fxcrt/cfx_retain_p...
File core/fxcrt/cfx_retain_ptr.h (right):

https://codereview.chromium.org/2536973003/diff/40001/core/fxcrt/cfx_retain_p...
core/fxcrt/cfx_retain_ptr.h:29: CFX_RetainPtr(std::nullptr_t ptr) {}
Can this go above, with the other constructors?

https://codereview.chromium.org/2536973003/diff/40001/core/fxcrt/cfx_retain_p...
File core/fxcrt/cfx_retain_ptr_unittest.cpp (right):

https://codereview.chromium.org/2536973003/diff/40001/core/fxcrt/cfx_retain_p...
core/fxcrt/cfx_retain_ptr_unittest.cpp:219: EXPECT_TRUE(ptr->HasOneRef());
Do we need more tests? For Retain() and Release()

[Tom Sepez, 2016-11-29 22:36:24]

https://codereview.chromium.org/2536973003/diff/40001/core/fxcrt/cfx_retain_p...
File core/fxcrt/cfx_retain_ptr.h (right):

https://codereview.chromium.org/2536973003/diff/40001/core/fxcrt/cfx_retain_p...
core/fxcrt/cfx_retain_ptr.h:29: CFX_RetainPtr(std::nullptr_t ptr) {}
On 2016/11/29 22:25:30, npm wrote:
> Can this go above, with the other constructors?

Done.  (Actually, the template at line 25 this is a ctor, too)

https://codereview.chromium.org/2536973003/diff/40001/core/fxcrt/cfx_retain_p...
File core/fxcrt/cfx_retain_ptr_unittest.cpp (right):

https://codereview.chromium.org/2536973003/diff/40001/core/fxcrt/cfx_retain_p...
core/fxcrt/cfx_retain_ptr_unittest.cpp:219: EXPECT_TRUE(ptr->HasOneRef());
On 2016/11/29 22:25:30, npm wrote:
> Do we need more tests? For Retain() and Release()

Done.

[npm, 2016-11-29 22:39:43]

lgtm

[Tom Sepez, 2016-11-29 22:40:19]

The CQ bit was checked by tsepez@chromium.org

[commit-bot: I haz the power, 2016-11-29 22:40:21]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-29 22:56:36]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1480459219189180,
"parent_rev": "f11380fc01cc17f05a34859d34c42b495c8ef8be", "commit_rev":
"b90c71a7b8530c5bd15740d0bb680f097920cd65"}

[commit-bot: I haz the power, 2016-11-29 22:56:39]

Description was changed from

==========
Add pdfium::MakeRetain<>() helper function.

Part of the work to get rid of |new|s.  Stripped from a forthcoming CL.
==========

to

==========
Add pdfium::MakeRetain<>() helper function.

Part of the work to get rid of |new|s.  Stripped from a forthcoming CL.

Committed:
https://pdfium.googlesource.com/pdfium/+/b90c71a7b8530c5bd15740d0bb680f097920...
==========

[commit-bot: I haz the power, 2016-11-29 22:56:40]

Committed patchset #4 (id:60001) as
https://pdfium.googlesource.com/pdfium/+/b90c71a7b8530c5bd15740d0bb680f097920...