Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(641)

Issue 2536973002: Roll Clang 287780-1:287780-2 (Closed)

Created:
4 years ago by hans
Modified:
4 years ago
Reviewers:
Reid Kleckner, Nico, pcc1, battre
CC:
chromium-reviews, eugenis+clang_chromium.org, vmpstr+watch_chromium.org, Lei Zhang, dsinclair, yunlian, glider+clang_chromium.org, Nico, ukai+watch_chromium.org, Reid Kleckner, hans, dmikurube+clang_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Roll Clang 287780-1:287780-2 This is the same version of Clang, but contains a patched version of LLVMgold.so to fix the problem of missing RUNPATH. BUG=668587 Committed: https://crrev.com/487d5289c3a7d58931a4ddb31655fce01a200e4a Cr-Commit-Position: refs/heads/master@{#434964}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M tools/clang/scripts/update.py View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 21 (11 generated)
hans
Please take a look.
4 years ago (2016-11-29 00:52:17 UTC) #3
Reid Kleckner
lgtm I affirm that we ran ldd and readelf to make sure it picks up ...
4 years ago (2016-11-29 00:59:19 UTC) #5
Nico
Lgtm
4 years ago (2016-11-29 01:25:56 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2536973002/1
4 years ago (2016-11-29 02:53:39 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_ozone_rel_ng/builds/280849)
4 years ago (2016-11-29 03:30:50 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2536973002/1
4 years ago (2016-11-29 03:38:16 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_asan_rel_ng/builds/270072)
4 years ago (2016-11-29 05:40:25 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2536973002/1
4 years ago (2016-11-29 10:11:45 UTC) #17
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-11-29 12:05:50 UTC) #19
commit-bot: I haz the power
4 years ago (2016-11-29 12:22:58 UTC) #21
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/487d5289c3a7d58931a4ddb31655fce01a200e4a
Cr-Commit-Position: refs/heads/master@{#434964}

Powered by Google App Engine
This is Rietveld 408576698