Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(415)

Unified Diff: content/browser/renderer_host/text_input_manager.h

Issue 2536943004: Fix a crash occuring during the destruction of TextInputManager on Android. (Closed)
Patch Set: Fixed a Compile Error in Test Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/renderer_host/text_input_manager.h
diff --git a/content/browser/renderer_host/text_input_manager.h b/content/browser/renderer_host/text_input_manager.h
index 0700d3241e1c584a5eb564b37cf3225e06741e34..eae15aa67be85f5aae776d01d6287e3d481ecf9d 100644
--- a/content/browser/renderer_host/text_input_manager.h
+++ b/content/browser/renderer_host/text_input_manager.h
@@ -37,7 +37,12 @@ class CONTENT_EXPORT TextInputManager {
// Called when a view has called UpdateTextInputState on TextInputManager.
// If the call has led to a change in TextInputState, |did_update_state| is
// true. In some plaforms, we need this update even when the state has not
- // changed (e.g., Aura for updating IME).
+ // changed (e.g., Aura for updating IME). Also note that |updated_view| is
+ // the view which has most recently received an update in TextInputState.
+ // |updated_view| should not be used to obtain any IME state since this
+ // this observer method might have been called in response to unregistering
Charlie Reis 2016/11/30 00:05:23 nit: this this
EhsanK 2016/11/30 00:34:25 Acknowledged.
+ // the |active_view_| from TextInputManager in which case all the the |view|
Charlie Reis 2016/11/30 00:05:23 nit: the the nit: What does "all the |view| is not
EhsanK 2016/11/30 00:34:25 Thanks. I rephrased this part.
+ // is not registered anymore.
virtual void OnUpdateTextInputStateCalled(
TextInputManager* text_input_manager,
RenderWidgetHostViewBase* updated_view,

Powered by Google App Engine
This is Rietveld 408576698