Fix a crash occuring during the destruction of TextInputManager on Android.

content/browser/renderer_host/render_widget_host_view_android.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/browser/renderer_host/render_widget_host_view_android.h"
 
 #include <android/bitmap.h>
 
 #include <utility>
 
@@ skipping 749 matching lines @@
   return reinterpret_cast<intptr_t>(&ime_adapter_android_);
 }
 
 // -----------------------------------------------------------------------------
 // TextInputManager::Observer implementations.
 void RenderWidgetHostViewAndroid::OnUpdateTextInputStateCalled(
     TextInputManager* text_input_manager,
     RenderWidgetHostViewBase* updated_view,
     bool did_change_state) {
   DCHECK_EQ(text_input_manager_, text_input_manager);
+  // If there are no active widgets, the TextInputState.type should be reported
+  // as none.
   const TextInputState& state =
-      *GetTextInputManager()->GetTextInputState(updated_view);
+      GetTextInputManager()->GetActiveWidget()
+          ? *GetTextInputManager()->GetTextInputState()

[Charlie Reis, 2016/11/30 00:05:23]

I assume it's intentional to remove |updated_view|, given your comment in
TextInputManager.

However, this appears to remove the only use of the |view| parameter to
GetTextInputState, which you added in
https://codereview.chromium.org/2354793003.  Can you remove that optional
parameter as a result?  (I much prefer to avoid optional parameters when we
can-- it's very hard to reason about when looking at either the code of the
function or the call sites on their own.)

[EhsanK, 2016/11/30 00:34:25]

I believe there is no use for it. I am removing it. We can always put it back
there if there is a legitimate reason for inquiring about TextInputState for a
specific view (it might come up along the path of fixing OOPIF IME for Android).

+          : TextInputState();
   if (state.is_non_ime_change && updated_view->GetRenderWidgetHost()) {
     // Sends an acknowledgement to the renderer of a processed IME event.
     updated_view->GetRenderWidgetHost()->Send(
         new InputMsg_ImeEventAck(host_->GetRoutingID()));
   }
 
   if (!content_view_core_)
     return;
 
   content_view_core_->UpdateImeAdapter(
@@ skipping 1208 matching lines @@
     case ui::MotionEvent::ACTION_UP:
     case ui::MotionEvent::ACTION_POINTER_UP:
       UMA_HISTOGRAM_CUSTOM_COUNTS("Event.Latency.OS.TOUCH_RELEASED",
                                   delta.InMicroseconds(), 1, 1000000, 50);
     default:
       return;
   }
 }
 
 }  // namespace content