Fix segfault in PpdProvider

Fix segfault in PpdProvider

We're derefferencing the unique_ptr after we've moved it which has
undefined behavior.  In this case, we get a segfault.

BUG=669266
Committed: https://crrev.com/ecd6d8eac060b4692c049840769dbcdac1196885
Cr-Commit-Position: refs/heads/master@{#434810}

[skau, 2016-11-28 23:23:51]

The CQ bit was checked by skau@chromium.org to run a CQ dry run

[skau, 2016-11-28 23:24:34]

skau@chromium.org changed reviewers:
+ justincarlson@chromium.org

[skau, 2016-11-28 23:24:34]

I copied this from your other CL.  Without it, I can't test my JS fix.

[commit-bot: I haz the power, 2016-11-28 23:25:49]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[justincarlson, 2016-11-28 23:27:50]

On 2016/11/28 23:24:34, skau wrote:
> I copied this from your other CL.  Without it, I can't test my JS fix.

Cool, sorry for the problem.  I'm still confused about why I didn't have this
crash when I initially ran this code.  I wouldn't think it's something that the
compiler would compile differently under normal circumstances.

[justincarlson, 2016-11-28 23:28:07]

justincarlson@google.com changed reviewers:
+ justincarlson@google.com

[justincarlson, 2016-11-28 23:28:08]

lgtm

[skau, 2016-11-28 23:33:32]

On 2016/11/28 23:27:50, justincarlson wrote:
> On 2016/11/28 23:24:34, skau wrote:
> > I copied this from your other CL.  Without it, I can't test my JS fix.
> 
> Cool, sorry for the problem.  I'm still confused about why I didn't have this
> crash when I initially ran this code.  I wouldn't think it's something that
the
> compiler would compile differently under normal circumstances.

The behavior after passing it to base::Bind is probably to coerce it to nullptr
somehow.  Technically the object is in a 'valid but unspecified' state.
http://en.cppreference.com/w/cpp/utility/move

[skau, 2016-11-28 23:34:39]

The CQ bit was checked by skau@chromium.org

[commit-bot: I haz the power, 2016-11-28 23:35:56]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-29 01:09:12]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1480376079345240, "parent_rev":
"8e7079e159eed597cc9f7bd7822074bd97048ab1", "commit_rev":
"bb3c492567bd4c2d425766ac53bc294158bb55ca"}

[commit-bot: I haz the power, 2016-11-29 01:09:39]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-11-29 01:19:59]

Description was changed from

==========
Fix segfault in PpdProvider

We're derefferencing the unique_ptr after we've moved it which has
undefined behavior.  In this case, we get a segfault.

BUG=669266
==========

to

==========
Fix segfault in PpdProvider

We're derefferencing the unique_ptr after we've moved it which has
undefined behavior.  In this case, we get a segfault.

BUG=669266

Committed: https://crrev.com/ecd6d8eac060b4692c049840769dbcdac1196885
Cr-Commit-Position: refs/heads/master@{#434810}
==========

[commit-bot: I haz the power, 2016-11-29 01:20:00]

Patchset 1 (id:??) landed as
https://crrev.com/ecd6d8eac060b4692c049840769dbcdac1196885
Cr-Commit-Position: refs/heads/master@{#434810}