Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(102)

Issue 2536903005: Fix expectation (Closed)

Created:
4 years ago by vsm
Modified:
4 years ago
Reviewers:
eernst, Brian Wilkerson
CC:
dev-compiler+reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fix expectation I copied over the new version of the test for sdk/tests and dropped the 'negative'. R=brianwilkerson@google.com Committed: https://github.com/dart-lang/sdk/commit/22f85df76ebe4404a1ff108e877fb6d054c6f157

Patch Set 1 #

Patch Set 2 : Fix #

Patch Set 3 : Revert summary change #

Patch Set 4 : Add tests #

Unified diffs Side-by-side diffs Delta from patch set Stats (+76 lines, -0 lines) Patch
A tests/language_strong/conditional_import_string_test.dart View 1 2 3 1 chunk +38 lines, -0 lines 0 comments Download
A tests/language_strong/conditional_import_test.dart View 1 2 3 1 chunk +38 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (5 generated)
vsm
4 years ago (2016-11-29 18:20:30 UTC) #3
Brian Wilkerson
lgtm
4 years ago (2016-11-29 18:25:56 UTC) #6
vsm
4 years ago (2016-11-29 18:28:35 UTC) #8
Message was sent while issue was closed.
Committed patchset #3 (id:40001) manually as
22f85df76ebe4404a1ff108e877fb6d054c6f157 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698