Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1131)

Issue 2536883002: Rename Image::drawTiled methods (Closed)

Created:
4 years ago by adenilson.cavalcanti
Modified:
4 years ago
CC:
chromium-reviews, krit, drott+blinkwatch_chromium.org, blink-reviews-platform-graphics_chromium.org, dshwang, pdr+graphicswatchlist_chromium.org, jbroman, Justin Novosad, Rik, f(malita), blink-reviews, danakj+watch_chromium.org, ajuma+watch_chromium.org, Stephen Chennney, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Rename Image::drawTiled methods As they evolved to be quite different and the amount of common code is minimal, it just make sense to define which member function is used to render borders and which is used for backgrounds. BUG=662504 Committed: https://crrev.com/7d224832bf10e21a898ce920921c862c0c600613 Cr-Commit-Position: refs/heads/master@{#434846}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -32 lines) Patch
M third_party/WebKit/Source/platform/graphics/GraphicsContext.cpp View 2 chunks +4 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/Image.h View 1 chunk +13 lines, -13 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/Image.cpp View 2 chunks +16 lines, -17 lines 0 comments Download

Messages

Total messages: 17 (12 generated)
cavalcantii1
4 years ago (2016-11-28 23:24:24 UTC) #8
Stephen Chennney
LGTM. I think this is a good solution to the problem.
4 years ago (2016-11-28 23:46:29 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2536883002/1
4 years ago (2016-11-29 01:48:02 UTC) #13
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-11-29 02:52:50 UTC) #15
commit-bot: I haz the power
4 years ago (2016-11-29 02:56:08 UTC) #17
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/7d224832bf10e21a898ce920921c862c0c600613
Cr-Commit-Position: refs/heads/master@{#434846}

Powered by Google App Engine
This is Rietveld 408576698